If you have more complicated permissions for commenting, MR11 won't work due to the first line in hook_entity_view_mode_alter()
:
if (!\Drupal::currentUser()->hasPermission('post comments')) {
return;
}
Since we're dropping this issue in favor of β¨ Don't rebuild the entire comment field/thread when posting a comment Needs work , quick fixes here could be:
- - Expanding the permission check to consider the comment creation on a per-entity, per-user basis, relying on the create permission for comment entities in the context of their parent entity.
- - Directly modifying the getter for the
view_mode
and patching it (or exposing it as a hook). The methodgetViewMode()
insrc/TempStore.php
.
If patching the getter, it might also be possible to removehook_entity_view_mode_alter()
entirelyβthough I haven't verified this.
I hope this saved a some time to someone still stuck on this issue. and hopefully soon β¨ Don't rebuild the entire comment field/thread when posting a comment Needs work will be solved and merged =)
Hi, patch #26 seems to work well. But it is conflicting with the
subgroup module β
.
The subgroup group-content plugin $content_entity_type_id
is group
, which is overridden by line 119
$tokens['group_content']['group'] = [
'name' => t('Group'),
'type' => 'group',
];
Hey, Thank you for the quick reply.
The code looks good, and I confirm it it fixes the issue =)
Hey! thanks!
I confirm the patch fixes the issue on RC2 of gin with 9.5.5 Drupal. (I also checked that nothing breaks in LTR =)
This is actually breaks functionality (maybe only in RTL), it causes the message to reappear after it was closed and only then to disappear.
I uploaded here a little patch, I added only the options that were available in the css of the library.
This is a duplicate of π CKEditor 5 isn't respecting field widgets row settings Fixed
i've created a MR. Let's review it and merge it! =)
Previous patch no longer applies. Here is a new patch.