πŸ‡«πŸ‡·France @Yonka

Nevache
Account created on 21 February 2020, about 5 years ago
#

Recent comments

πŸ‡«πŸ‡·France Yonka Nevache

If you have more complicated permissions for commenting, MR11 won't work due to the first line in hook_entity_view_mode_alter():

if (!\Drupal::currentUser()->hasPermission('post comments')) {
    return;
}

Since we're dropping this issue in favor of ✨ Don't rebuild the entire comment field/thread when posting a comment Needs work , quick fixes here could be:

  1. - Expanding the permission check to consider the comment creation on a per-entity, per-user basis, relying on the create permission for comment entities in the context of their parent entity.
  2. - Directly modifying the getter for the view_mode and patching it (or exposing it as a hook). The method getViewMode() in src/TempStore.php.
    If patching the getter, it might also be possible to remove hook_entity_view_mode_alter() entirelyβ€”though I haven't verified this.

I hope this saved a some time to someone still stuck on this issue. and hopefully soon ✨ Don't rebuild the entire comment field/thread when posting a comment Needs work will be solved and merged =)

πŸ‡«πŸ‡·France Yonka Nevache

Hi, patch #26 seems to work well. But it is conflicting with the subgroup module β†’ .
The subgroup group-content plugin $content_entity_type_id is group, which is overridden by line 119

  $tokens['group_content']['group'] = [
    'name' => t('Group'),
    'type' => 'group',
  ];
πŸ‡«πŸ‡·France Yonka Nevache

Hey, Thank you for the quick reply.
The code looks good, and I confirm it it fixes the issue =)

πŸ‡«πŸ‡·France Yonka Nevache

Hey! thanks!
I confirm the patch fixes the issue on RC2 of gin with 9.5.5 Drupal. (I also checked that nothing breaks in LTR =)

πŸ‡«πŸ‡·France Yonka Nevache

Yoa β†’ created an issue.

πŸ‡«πŸ‡·France Yonka Nevache

This is actually breaks functionality (maybe only in RTL), it causes the message to reappear after it was closed and only then to disappear.

I uploaded here a little patch, I added only the options that were available in the css of the library.

πŸ‡«πŸ‡·France Yonka Nevache

i've created a MR. Let's review it and merge it! =)

πŸ‡«πŸ‡·France Yonka Nevache

Previous patch no longer applies. Here is a new patch.

Production build 0.71.5 2024