- Issue created by @project update bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module โ these changes make this module compatible with Drupal 11! ๐
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot โ to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #11-120835This patch was created using these packages:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.7
- palantirnet/drupal-rector: 0.20.1
- First commit to issue fork.
- ๐ฆ๐บAustralia VladimirAus Brisbane, Australia
vladimiraus โ changed the visibility of the branch 3429235-automated-drupal-11 to hidden.
- ๐ฆ๐บAustralia VladimirAus Brisbane, Australia
See CI report. More work required.
- ๐ฆ๐บAustralia alex.skrypnyk Melbourne
@vladimiraus
I see you added CI that is now reporting issues that have been present in the module for a long time.
Is it possible to do the D11 upgrade as-is and fix those code standards violations in another issue? - Status changed to Needs work
3 months ago 6:22am 9 December 2024 - ๐ฆ๐บAustralia VladimirAus Brisbane, Australia
All good. Thanks @alex.skrypnyk.
- ๐ฆ๐บAustralia VladimirAus Brisbane, Australia
There is work happening in
hook_file_validate()
fix in โจ Remove deprecated hook_file_validate() and implement Constraint plugins Active . - ๐ฆ๐บAustralia VladimirAus Brisbane, Australia
Only dependency injections are left.
As there is work on refactoring is happening in 4.0.x, I won't be doing it here.
- ๐ฆ๐บAustralia jannakha Brisbane!
hook_file_validate() will be replaced with event handler in this task
issue #3423615 was not implemented for this module
- First commit to issue fork.
- ๐ฆ๐บAustralia VladimirAus Brisbane, Australia
@smustgrave - thanks for your commit, but you changes do not bring full D11 compatibility e.g. `hook_file_validate()` was removed from D11.
Can you create separate issue for phpcs and issues for any other CI tasks?
Cheers ๐ - ๐ฆ๐บAustralia VladimirAus Brisbane, Australia
Changing branch for D11 support.
- ๐บ๐ธUnited States smustgrave
Confused on the game plan here.
1. Is a new branch starting for 10.3/11
2. In slack you mentioned the hold up was phpstan stuff - ๐ฆ๐บAustralia jannakha Brisbane!
@smustgrave I think there is some confusion.
D11 compatibility is not fully implemented. File scanner is not working.
Please do phpcs separately once 2.1.0 release is done. - ๐บ๐ธUnited States smustgrave
Thanks but Iโm good donโt know the direction this project is trying to go so will just wait for the D11 release. Thanks!
- ๐ฆ๐บAustralia jannakha Brisbane!
Tested on Drupal 11. File scanning is working with executable and not allowing to upload the file when execution is disabled.
-
vladimiraus โ
committed f0a409c4 on 2.1.x authored by
jannakha โ
Issue #3429235 by vladimiraus, jannakha, project update bot, smustgrave...
-
vladimiraus โ
committed f0a409c4 on 2.1.x authored by
jannakha โ
- ๐ฆ๐บAustralia VladimirAus Brisbane, Australia
Thanks @jannakha & @smustgrave.
That looks good.
Tested MR!15. Works as expected.
Merging and testing MR!12. - ๐ฆ๐บAustralia VladimirAus Brisbane, Australia
Last sanity check.
- phpcs should be separate issue
- phpstan only contains dependency injection warning which should be another issue
- ๐ฆ๐บAustralia jannakha Brisbane!
works as required.
Thank you for your contributions and support!
Hurray for D11 -
vladimiraus โ
committed 2e999613 on 2.1.x authored by
project update bot โ
Issue #3429235 by vladimiraus, jannakha, project update bot, smustgrave...
-
vladimiraus โ
committed 2e999613 on 2.1.x authored by
project update bot โ
- ๐ฆ๐บAustralia VladimirAus Brisbane, Australia
Cheers @everyone who was working on this issue. ๐ฅ
Big kudos to DrevOps โ for sponsoring the release. ๐ฅณ
Committed! ๐ฐ - ๐ธ๐ฎSlovenia KlemenDEV
Thank you for work on this and big thanks to the sponsors!
- Status changed to Fixed
14 days ago 1:19pm 9 February 2025 Automatically closed - issue fixed for 2 weeks with no activity.