[regression] Menu links reparenting via interface could lead to unusable broken menus

Open on Drupal.org →

Created on 6 July 2016, almost 9 years ago

Updated 3 June 2025, 3 days ago

Problem/Motivation

Menu links reparenting via interface could lead to unusable broken menus.

This could lead to major issues with some users, specially since when you try to fix the menu using the interface, it tends to scramble even more, leading (depending on the depths you're using) to unusable menus, only fixed by editing the database directly.

Steps to reproduce

Create a new menu on the interface (/admin/structure/menu/manage/) with a structure like this:
- Link 1
  - Link 1.1
  - Link 1.2
- Link 2
- Link 3
Save and then reorder the menu to this sequence:
- Link 1.2
  - Link 1
  - Link 1.1
- Link 2
- Link 3
Save

What is expected:

The menu should be saved correctly with the new order.

What happens instead:

The menu order gets scrambled to something like this:

Link 1
Link 1.2
- Link 1.1
Link 2
Link 3

Proposed resolution

TBD

Remaining tasks

Reroll #33
Fix issue / get tests passing
Reviews

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Needs work

Version

11.0 🔥

Component

Menu system →

Last updated 3 days ago

Maintained by
🇩🇪Germany @dawehner
🇺🇸United States @pwolanin

Created by

🇧🇷Brazil ivan.lewas

Live updates comments and jobs are added and updated live.

Bug Smash Initiative

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Needs Review Queue Initiative
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.

Incomplete comments

Sign in to follow issues

Merge Requests

!12300[regression] Menu links reparenting via interface could lead to unusable broken menus
Open
🇦🇺Australia acbramley
updated 3 days ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 2 years ago →
🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

This still needs tests.
First commit to issue fork.
Merge request !12300Issue #2761755: Menu links reparenting via interface could lead to unusable broken menus → (Open) created by acbramley
Comment 3 days ago →
🇦🇺Australia acbramley
Reproduced this and the patch from #50 fixed it nicely. Rolling into an MR, still needs tests.
Pipeline finished with Success
3 days ago
Total: 783s
#512848
Comment 3 days ago →
🇦🇺Australia acbramley
Had a look through tests and I think this will be very hard to cover without being flakey.

AFAICT it needs to be in a JS test to do the draggable stuff (reparenting isn't supported on the menu form without javascript). We have a functional test in MenuLinkReorderTest which does almost nothing, and the existing JS test coverage only tests contextual links.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024