Menu links reparenting via interface could lead to unusable broken menus.
This could lead to major issues with some users, specially since when you try to fix the menu using the interface, it tends to scramble even more, leading (depending on the depths you're using) to unusable menus, only fixed by editing the database directly.
What is expected:
The menu should be saved correctly with the new order.
What happens instead:
The menu order gets scrambled to something like this:
TBD
Reroll #33
Fix issue / get tests passing
Reviews
Needs work
10.1 ✨
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
This still needs tests.