In order to add target="_blank" to a file link, I had to replicate most of template_preprocess_file_link. The documentation for $variables['attributes'] ("An associative array of attributes to be placed in the a tag") is wrong after 📌 Use CSS for file icons in file fields Fixed
Add URL options variable to the template which includes attributes. See #29
This may be deprecated eventually: #2615660: Allow Link and LinkGenerator::generate() to provide attributes. →
Review the patch and change record.
Needs work
10.1 ✨
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
@imclean I do think this could use a test case. To least show that altering works as expected.