- 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
For the tests requested in #10.
Also the issue summary could use an update as it references D10 a lot.
- Status changed to Needs review
about 2 years ago 11:59am 21 April 2023 - last update
about 2 years ago 29,301 pass - 🇮🇳India mohit_aghera Rajkot
- last update
about 2 years ago 29,289 pass, 2 fail The last submitted patch, 30: test-only-2887144-30.patch, failed testing. View results →
- Status changed to RTBC
about 2 years ago 12:11am 22 April 2023 - 🇺🇸United States smustgrave
Issue summary looks good.
Tests-only patch in #30 shows the failure I think perfectly, good job @mohit_aghera!
Applied cleanly and everything appears to function as normal.
- last update
about 2 years ago 29,303 pass - last update
about 2 years ago 29,301 pass - last update
about 2 years ago Build Successful - last update
about 2 years ago 29,367 pass - last update
about 2 years ago 29,368 pass - last update
about 2 years ago 29,375 pass - last update
about 2 years ago 29,379 pass - last update
about 2 years ago 29,380 pass - last update
about 2 years ago 29,358 pass, 2 fail The last submitted patch, 30: 2887144-30.patch, failed testing. View results →
- Status changed to Needs work
about 2 years ago 6:19am 10 May 2023 - Status changed to Needs review
about 2 years ago 10:36am 17 May 2023 - 🇮🇳India mohit_aghera Rajkot
Triggering the test bot again for patches in #30.
Failures are inCkEditor5\FunctionalJavascript\MediaTest
- last update
about 2 years ago 29,365 pass, 4 fail The last submitted patch, 30: 2887144-30.patch, failed testing. View results →
- Status changed to Needs work
about 2 years ago 11:40am 17 May 2023 - last update
about 2 years ago 29,389 pass - First commit to issue fork.
- 🇭🇺Hungary mxr576 Hungary
The failing test confirms that even with 🐛 Extend ViewsBlockBase to merge cache metadata from display handler Active merged into Drupal core, this issue still persists. The cacheability metadata from the View config entity is still not bubbling up to the block, so the underlying problem remains unresolved.
Relying on
View::getCacheTags()
should be a better solution instead of a hand-crafted config cache id, since\Drupal\views\Entity\View::addCacheMetadata()
ensures that before a View config is changed display plugin's cacheability information is also incorporated into the stored cache tags.Question: What about cache contexts and cache max age bubble up from Views?
The merge request is currently failing due to the test coverage introduced in 🐛 Extend ViewsBlockBase to merge cache metadata from display handler Active , which added significant amounts of mocking. Somebody has to fix those, because I tried and failed miserably due to interconnected dependencies and protected properties... (This is one of the main reasons I try to avoid overusing mocks in my own projects - they tend to make the test suite fragile and harder to maintain.
</personal_opinion>
)(There may also be a related issue in the contrib space: 🐛 Filter configuration changes does not propagate immeditelly to BEF in a block Active .)