- 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
Seems there was a test failure in the MR.
Hiding patch as fix is in MR.
- 🇮🇳India mohit_aghera Rajkot
I tried to reproduce the issue manually using following approach:
My menu tree looks like given below
- Home
- Parent (path: node/)
--Node 1 (active) (path: node/1)
--Node 2 (disabled) (path: node/2)Now when I visit node/2 in the browser directly, i can see proper menu tree in the UI
Besides, I don't see any `is-active` class applied to Parent or Home menu links.
Can we get additional steps to reproduce the issue. - 🇫🇷France prudloff Lille
prudloff → changed the visibility of the branch 9.2.x to hidden.
- 🇫🇷France prudloff Lille
prudloff → changed the visibility of the branch 11.x to hidden.
- 🇫🇷France prudloff Lille
prudloff → changed the visibility of the branch 2973515-menuactivetrail-should-ignore to hidden.
- 🇫🇷France prudloff Lille
I added steps to reproduce and created a new MR that targets 11.x.
- 🇺🇸United States smustgrave
https://git.drupalcode.org/issue/drupal-2973515/-/jobs/4680214 shows the test coverage and the actual fix seems pretty straight forward to me.
- 🇬🇧United Kingdom catch
I left a minor comment on the MR, which is a bit of a nitpick and I'm 50/50 whether it's in scope or not. Leaving at RTBC for now.