Not all unit tests with a custom setUp() method are currently calling the parent setUp() method, where the Drupal container is unset:
/**
* {@inheritdoc}
*/
protected function setUp() {
parent::setUp();
// Ensure that an instantiated container in the global state of \Drupal from
// a previous test does not leak into this test.
\Drupal::unsetContainer();
$this->root = dirname(dirname(substr(__DIR__, 0, -strlen(__NAMESPACE__))));
}
For now this is inoccuous (as the tests pass anyway), but as it is inconsistent it may lead to confusion down the line, when we put further checks/set up functionality in UnitTestCase::setUp(). Also, if new contributors look at an existing test for "inspiration", they may forget to call the parent setUp() method and have the global state of \Drupal from a previous test leak into their own test.
Call parent::setUp() in all unit tests with a custom setUp() method.
Or alternatively: do important checks elsewhere (DrupalStandardsListener?)
Review patch
None
None
Needs work
10.1 ✨
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
This still seems to be relevant for some of these files but some have been fixed/updated.
So we will need a reroll for 10.1.x