- Issue created by @spokje
- 🇮🇹Italy mondrake 🇮🇹
Here, please beware of #3326239-7: Add phpstan/phpstan-phpunit as a dev dependency → :
I added to baseline a few missing calls to
parent::setUp()
in base test classes, since their setUp() methods are making unconventional things.i.e. they would need IMHO a much deeper discussion if we want to clean them up
- 🇳🇱Netherlands spokje
Thanks @mondrake for the heads-up.
I was already aware that there are some out there that can't/won't be fixed in here.
Will explicitly note them down in the IS, for now that's just a c/p from a template, so it still mentions all and everything will be fixed. - @spokje opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 11:29am 30 March 2023 - Status changed to RTBC
over 1 year ago 2:11pm 30 March 2023 - 🇺🇸United States smustgrave
Applied the MR and all the instances of Missing call to parent are removed from phpstan-baseline except the 4 mentioned.
The passing tests show this didn't break anything. - 🇳🇱Netherlands spokje
Rebased after 📌 Fix PHPStan L1 errors "@covers value \Foo\Bar::baz() references an invalid method." Fixed was committed.
- 🇳🇱Netherlands spokje
Rebased after 📌 Fix PHPStan L1 errors "Annotation "@covers::foo" is invalid, "@covers" should be followed by a space and a value." Fixed was committed.
- Status changed to Needs work
over 1 year ago 4:02pm 13 April 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to RTBC
over 1 year ago 4:24pm 13 April 2023 - 🇮🇹Italy mondrake 🇮🇹
Filed 📌 Fix missing call to parent::setUp() in remaining tests Fixed for follow-up.
- last update
over 1 year ago 29,202 pass -
longwave →
committed 596b3d38 on 10.1.x
Issue #3351236 by Spokje, mondrake, smustgrave: Fix PHPStan L1 errors "...
-
longwave →
committed 596b3d38 on 10.1.x
- Status changed to Fixed
over 1 year ago 6:24am 1 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.