Fix missing call to parent::setUp() in remaining tests

Here's a patch.

Marking this but there are 135 instances of Missing call to parent how are they being covered?

#3 see parent issue

Hm, can DrupalKernelTest just override bootKernel() to do nothing?

Personally, I think this is more readable and gives more flexibility, than starting to override the base methods that setup the environment. Also, this is kind of a reference issue for further work - there are other similar issues (see 📌 Fix PHPStan L1 errors "Missing call to parent::setUp()/tearDown() method." Fixed ) but for BrowserTestBase.

+++ b/core/tests/Drupal/KernelTests/KernelTestBase.php
@@ -247,6 +247,16 @@ protected function setUp(): void {
+   * Extending tests may override this to tune their boot level to their
+   * specific need.

If this method is about the boot level, could we give it a name that reflects that?

I'm really not keen on Foo()/doFoo() pairs.

Would ::kernelSetUp() be a better option?

Looks good and fixes the PHPStan reported errors. I would have preferred my own way… but that’s not a matter to prevent rtbc. Thanks!

needs rebase

Rebase seems good.

Needs a reroll.

longwave suggested a followup in #11. Has that been made?

Re-rolled patch #14. Removed re-rolled tag. please review

Back to RTBC

Rerolled, opened follow-up 📌 Simplification in UpdatePathTestBase Fixed (thanks @quietone)

The last submitted patch, 19: 3354063-19.patch, failed testing. View results →

Looks like a random fail: https://www.drupal.org/project/drupal/issues/2829040#comment-15050937 🌱 [meta] Known intermittent, random, and environment-specific test failures Active

Yea a number of tickets are getting this random

The last submitted patch, 19: 3354063-19.patch, failed testing. View results →

Rerolled 3354063-19_0.patch on 11.x-dev in MR

Committed and pushed 7e4ecad537 to 11.x (10.2.x). Thanks!

Spokje → closed merge request !4055

Automatically closed - issue fixed for 2 weeks with no activity.