- πΊπΈUnited States smustgrave
Self review.
This will need a test case.
The update_manager_file_get()
function checks the argument url against a small hard-coded list of remote file schemes, and assumes that all other URIs may be resolved to paths on the local filesystem. This assumption is wrong and unnecessary. The code may be made simpler and more robust by simply passing the URI to \Drupal::service('file_system')->realpath()
A return value of FALSE
indicates that the scheme does not support translation to a local filesystem path.
The code should be modified as described above.
Review patch
Commit
None.
None.
Needs work
9.5
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Self review.
This will need a test case.