Contrib.social

change maintenance mode page checkbox to radios

Open on Drupal.org →
Created on 27 January 2019, almost 6 years ago
Updated 14 June 2023, over 1 year ago

Problem/Motivation

The maintenance mode page has a checkbox that says:

> Put site into maintenance mode

Checkboxes that have an action are ambiguous and confusing. I for one have to reread this every time I visit the maintenance mode page.

What does it mean if you come to the page, and the checkbox is already enabled, and you save the page? Are you going to 'put it into' maintenance mode *again*? (This is something you might feasibly do, to change the maintenance mode message from 'We'll be back at 1200' to 'We'll be back tomorrow', during a particularly difficult site update, say.)

Steps to reproduce

go to admin/config/development/maintenance

Proposed resolution

( ) Site is in normal operation
(*) Site is in maintenance mode
Visitors will only see the maintenance mode message. Only users with the "Use the site in maintenance mode" permission will be able to access the site. Authorized users can log in directly via the user login page.

Remaining tasks

Usability review

User interface changes

Yes, to admin/config/development/maintenance

Current

Proposed

API changes

Data model changes

Release notes snippet

✨ Feature request
Status

Needs work

Version

11.0 🔥

Component
System  →

Last updated 2 days ago

No maintainer
Created by

🇬🇧United Kingdom joachim

Live updates comments and jobs are added and updated live.
  • Usability

    Makes Drupal easier to use. Preferred over UX, D7UX, etc.

  • Needs usability review

    Used to alert the usability topic maintainer(s) that an issue significantly affects (or has the potential to affect) the usability of Drupal, and their signoff is needed. When adding this tag, make it easy to review the issue. Make sure the issue summary describes the problem and the proposed solution. Screenshots usually help a lot! To get sign-off on issues with the "Needs usability review" tag, post about them in the #ux channel on Drupal Slack, and/or attend a UX meeting to demo the patch and get direct feedback from designers/UX folks/product management on next steps. If an issue represents a significant new feature, UI change, or change to the general "user experience" of Drupal, use Needs product manager review instead. See the scope of responsibilities for product managers.

  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

  • Needs screenshots

    The change alters the user interface, so before and after screenshots should be added to document the UI change. Make sure to capture the relevant region only. Use a tool such as Aviary on Windows or Skitch on Mac OS X.

  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇺🇸United States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

    This feels more like a feature request. Think some simple test coverage should be added.
    Also with the UX change screenshots in the issue summary will be useful.

    Also did anyone see if this causes schema issues? I imagine it will as it's an adding a different option vs boolean

    If it does then an upgrade will be needed for existing sites.

    Thanks

  • Comment almost 2 years ago →
    🇮🇳India Akram Khan Cuttack, Odisha

    reroll patch against 10.1.x

  • Comment almost 2 years ago →
    🇺🇸United States smustgrave

    Patch #21 applied fine to d10 so how did you generate an interdiff in 26?

  • Status changed to Needs review over 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.2 & MySQL 8
    last update over 1 year ago
    29,436 pass
  • Comment over 1 year ago →
    🇮🇳India ranjith_kumar_k_u Kerala

    Added tests, please review

    we added radio option values as 0 and 1 and also there is type casting in the default value section as well as the saving part, so no upgrade is needed for the existing sites.

  • Comment over 1 year ago →
    🇫🇮Finland lauriii Finland

    I think we'll need to also update the description because it was written in a way that makes sense for the checkbox.

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States smustgrave

    Could point

    The phrase

    What does it mean if you come to the page, and the checkbox is already enabled, and you save the page? Are you going to 'put it into' maintenance mode *again*?

    seems like you would experience the same if it were radio or checkbox.

  • Comment over 1 year ago →
    🇳🇱Netherlands yoroy

    I'm wondering if the current situation really is a stumbling block for peope? Not to deny or disparage the initial report but over the four years since this was opened nobody chimed in with similar doubts about how this confuses them and this is certainly not fixing some currently broken situation.

    Without further evidence on this being an actual problem I'm leaning towards a won't fix for this.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024