Views RSS row plugin incorrectly assumes links are relative

Was tagged for tests in #34 which still needs to happen.

Did not test patch.

#42 Patch works for me (9.5.5 PHP 8.1) for a site running the Domain module. One caveat is that if you have Twig debugging enabled the field comments will passed into fromURI() which isn't a problem on production sites.
InvalidArgumentException: The URI ' <!-- THEME DEBUG --> <!-- THEME HOOK: 'views_view_field' --> <!-- BEGIN OUTPUT from 'core/themes/stable/templates/views/views-view-field.html.twig' -->

Attached patch is a small code cleanup to not duplicate calling $this->getField($row_index, $this->options['link_field']) twice.

Oops, this fixes a syntax error.

Updated patch with further cleanup of duplicate calls to $this->getField($row_index, $this->options['link_field'])

The attached patch will fix the errors with twig debugging enabled. Core without this patch would not error but would create urls were invalid - "http://www.mysite.com/%20%3C%21--%20THEME%20DEBUG%20--%3E%20%3C%21--%20T..."

Pending: new test to test an external url used for the RSS link.

The attached patches add the new feed field test to check field configured to output an absolute URL.

• "2918784-55--fix-and-tests.patch": This is the fix from #54 along with the new tests. This should PASS.
• "2918784-55--tests-only.patch": This is 11.x with the new tests. This should FAIL.

Issue summary should be updated, not super clear what the proposed solution is.

Added the template to be filled in by someone familiar with the issue.

Removing tests tag as #56 shows they were added.

Removing IS update tag as that was completed in #59

Following the steps in the IS I was able to reproduce the issue
Patch #58 did solve it, and reran the tests for php8.2 and think failure was unrelated.
Also tests-only patch was provided in #58 that shows the issue.

Think this one is good.

The last submitted patch, 56: 2918784-55--fix-and-tests.patch, failed testing. View results →

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

created MR 5437 with 2918784-55--fix-and-tests.patch

Added some feedback to the MR.

I'm getting an error that You are not allowed to specify an external URL together with internal:/. in Drupal\Core\Url::fromInternalUri() which is annoying because that's exactly what I want to do: our feeds may link to content on the same domain using the view_node internal link to content, or on one of our other domains using a link field which may contain an external absolute link.

The #15 fix on Improve behavior of RSS view with fields if you enabled "Use absolute link" 📌 Improve behaviour of RSS view with fields if you enabled "Use absolute link" Active lets me mix'n'match as I need to by allowing valid absolute links to pass right through the getAbsoluteUrl function.

There's obviously a lot more going on in this MR but I'm hoping that at the end of the day, I can be allowed to specify external URLs together with internal. Thanks!

the following MR's have been updated per the MR feedback on MR 5438:
11.x: MR 5437
10.1.x: MR 5438

attached a 11.x static patch for composer builds

smustgrave → changed the visibility of the branch 2918784-10.1.x to hidden.

Hiding the 10.1 so we just have the 11.x MR.

For the comments around using trim() and striptags()

Depending on the views configuration, the $this->getField($row_index, $this->options['link_field']); could return markup.

If this is needed for the fix believe we maybe should have coverage also around when markup is used. To show that it is indeed needed.

Thanks.

I just upgraded to 10.3.x and it said the patch failed.. which one should I use for 10.3.1?