Contrib.social

Cron runs can break styling in Views that use search index view mode

Open on Drupal.org →
Created on 2 December 2020, over 4 years ago
Updated 31 January 2023, about 2 years ago

Problem/Motivation

Cron running in conjunction with a View content format using the "Search index" view mode results in recently updated nodes to render unstyled in the view. (If cache is not cleared before the View is rendered.)

This happens for anonymous users, not for logged in users. (Edit: I would note that a workaround is to use a different view mode. E.g. "Search result highlighting input" or "Teaser" etc.)

We came across this behaviour on a client site (8.9.9) and I have confirmed it on a vanilla install of 9.0.9.

Steps to reproduce

  1. Enable the "Search index" view mode for a content type. (e.g. Basic page)

  2. Use a View to display a list of nodes, using the "Search index" view mode.

  3. As an anonymous user, visit the View page, note styling. (For the screenshot, I used a View to list search results, but this happens with any old listing of nodes in a View.)

  4. Update (or simply resave) one of the nodes that are displayed by the View.
  5. Run cron. (Do not clear cache.)
  6. Still as an anonymous user, reload the View page. The styling for the updated node has changed.

Proposed resolution

Add "max-age" cache key to render array in indexNode() and set it to zero, so cron's subsequent indexing of the updated node does not break styling for anonymous users.

🐛 Bug report
Status

Needs work

Version

10.1 ✨

Component
Node system  →

Last updated about 13 hours ago

No maintainer
Created by

🇪🇪Estonia mmatsoo

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 2 years ago →
    🇺🇸United States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

    Started tests for #2 on 10.1.x

    This was previously tagged for tests which still need to happen.

    Did not test issue.

  • Status changed to Needs review 11 months ago
  • Comment 11 months ago →
    🇺🇸United States apotek

    This patch seems to work as advertised. I don't know why this issue was taken from needs review to needs work without feedback. What is the patch lacking? Can that be made explicit? Putting this back to needs review.

  • Status changed to Needs work 11 months ago
  • Comment 11 months ago →
    🇺🇸United States smustgrave

    This was previously tagged for tests which still need to happen.

    See #13

  • Comment 8 days ago →
    🇦🇺Australia acbramley

    This is still reproducible on 11.x

    I don't really understand why this is happening in the first place, nor why the fix fixes it, we should definitely add some comments if that really is the proper fix.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024