.container-inline: nested checkbox should not get the trailing ":"

Can confirm this fixes the issue.

The same CSS is in starterkit_theme and Umami; should the same fixes be applied there?

Also, we have a similar rule for radios, so is it worth adding the same fix for .container-inline .form-type--radio label:after?

Umami maybe? Would need to see this scenario from a frontend standpoint. (Screenshots needed)
Starterkit_theme I think yes as this could be copied for a backend theme maybe?

Updated it for radio element as well.
Also, Made changes in Starterkit_theme and Umami theme.

Umami maybe? Would need to see this scenario from a frontend standpoint. (Screenshots needed)

\
Tried finding a scenario where it is used, but didn't find any. We're using same CSS for all, to keep it uniform updated it in umami as well.

Applied the same fix in the Starterkit_theme.

I tested the Patch #12 and it is working fine. Please find the attached image for the results.

Thank You!!

The last submitted patch, , failed testing. View results →

The last submitted patch, 13: 3329699-12.patch, failed testing. View results →

+++ b/core/profiles/demo_umami/themes/umami/css/classy/components/container-inline.css
@@ -7,6 +7,8 @@
+.container-inline .form-type-radios label:after,

Should this be .form-type-radios or .form-type--radio?

I suppose we need a form with inline radio buttons to be able to actually test this.

Should this be .form-type-radios or .form-type--radio?

Yes it is .form-type--radio. I have updated the patch.

@Gauravvvv Thanks for the work. I have applied your patch its working fine on chrome and Firefox browser and also attached the screenshot for the same

hey @Gauravvvv, applied the patch on #43 and it works completely, but you have not updated the class name from this .form-type-radios to .form-type--radio so moving it to need work again

Updated selector and attached interdiff.

The last submitted patch, 25: 3329699-25.patch, failed testing. View results →

I have created an MR , Please review.

.container-inline .form-item label:last-child::after {
  content: none;
}

This CSS code will remove the trailing colon from the label of the last checkbox in a group of nested checkboxes inside an element with the class ".container-inline".

Hope this works. Thanks

I believe #20 was correct. I can't find any reference to form-type--radio in the repo.

If the MR 3168 is the way. Explain why with screenshots.

Just fixed the merge conflict for MR 3168.

@kunal_sahu's work made me realize we have to handle 2 cases: with and without description. For elements with a description, keeping the trailing ':' could make sense (notice the gray description right after "Reversed:"):

Looking at the original code, it looks like the trailing ':' was added precisely to care for the with-description case.

Taking all this into account, I'll try using only the :last-child selector. If results look good, I'll push a new commit to the MR.

@smustgrave: I was able to see .form-type--radio in the HTML source, probably constructed dynamically.

Attaching the patch for the current state of the MR.

New patch works great, IMHO:

Can before/after screenshots be updated.
Also can the MR be updated for 11.x please

Believe jedihe is working on this so please no one vulture it.

Thanks!