NodeTypeForm::validateForm doesn't validate HTML for description

The patch in #16 is still valid against 10.1.x

2978818-16-tests-only.patch reproduced it, and 2978818-16.patch fixed it.

Tagging "Needs Review Queue Initiative" because I saw the NR request in #needs-review-queue-initiative on slack.

It looks like the proposed resolution doesn't actually match what is in the issue summary. Proposed solution seems to be to do it on runtime to not run into the same problem with translations. The downside of that solution is that it could interfere with existing markup but overall doing it runtime seems more in line with how we do markup normalization in other places because this way we can solve it for all different use cases.

Still valid, I tested #20 i.e doing Html::normalize at runtime in template_preprocess_node_add_list but it didn't work, I have no idea why though, debugging into the preprocess showed valid markup in the description variables. (EDIT: claro_preprocess_node_add_list also needed the fix)

Also, these descriptions are shown elsewhere such as on admin/structure/types so I don't think it makes sense to do it at runtime.

Seems like a good update

1) Drupal\Tests\node\Functional\NodeTypeTest::testNodeTypeEditing
Behat\Mink\Exception\ExpectationException: The string "<em>Lorem ipsum.</em>" was not found anywhere in the HTML response of the current page.
/builds/issue/drupal-2978818/vendor/behat/mink/src/WebAssert.php:888
/builds/issue/drupal-2978818/vendor/behat/mink/src/WebAssert.php:363
/builds/issue/drupal-2978818/core/tests/Drupal/Tests/WebAssert.php:559
/builds/issue/drupal-2978818/core/modules/node/tests/src/Functional/NodeTypeTest.php:160
FAILURES!
Tests: 6, Assertions: 95, Failures: 1.
Exiting with EXIT_CODE=1

Shows the test coverage

Great extension of an existing test.

LGTM.

I would prefer not changing the user input since that wouldn't solve the use case of a bad translation. Good news is that the tests shouldn't need to be changed, we only need to change how it's solved :)

A problem in the translation can create issues like 🐛 CKEditor 5 toolbar configuration not show buttons in spanish installation Active .

Also the issue summary and the solution are not the same.

@nod_ what's the proposed solution then? Calling the same thing anywhere the node type's description is used?