- 🇺🇸United States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
Such a feature will require test coverage
- 🇺🇸United States mpotter
Patch in #20 works great in D9.5.x. This is super useful and much better than the default behavior.
- 🇺🇸United States foodslover
The changes made in Patch #18 & #20 caused an issue where the system attempted to find an entity type called "view_id," which doesn't actually exist in Drupal. This led to an error message: `Drupal\Component\Plugin\Exception\PluginNotFoundException: The "view_id" entity type does not exist. in Drupal\Core\Entity\EntityTypeManager->getDefinition()` when a user accessed the URL `/admin/config/search/redirect`.
The latest patch has fixed these bugs, ensuring that when using the current version of Drupal 9.5 & 10.1.6, this error no longer occurs when accessing the specified URL.
This revised code attempts to utilize entity titles for internal URLs. It checks if the provided entity type exists in Drupal before attempting to load an entity. If an entity is loaded successfully, it checks for translations and retrieves the title or name field. For cases where route parameters are absent, it loads links by route and sets the root menu item's title.
Key modifications:
- Check Entity Type Definition: Before attempting to load an entity, hasDefinition() checks if the provided entity type exists in Drupal. This prevents attempting to load non-existent entity types.
- Entity Loading and Field Handling: After confirming the existence of the entity type, getStorage() is used to retrieve the entity storage handler.
- 🇺🇸United States kmonahan
Using this patch and found an issue where, when the Link formatter is used to display the URL only as plain text, the node title is still displayed instead of the URL. Will take a look and update the patch.
- First commit to issue fork.
- Merge request !8386Issue #3151609: Use entity title for link text when link text is empty. → (Open) created by manish-31
- Status changed to Needs review
5 months ago 10:42am 12 June 2024 - 🇮🇳India manish-31
Opened an MR.
Added tests for this change and minor coding standard fixed from patch #36. Needs review. - Status changed to Needs work
5 months ago 1:22pm 12 June 2024 - 🇺🇸United States smustgrave
Issue summary appears to have broken images can those be updated.
Left small comment on MR.
- Status changed to Needs review
5 months ago 5:15pm 12 June 2024 - Status changed to Needs work
5 months ago 4:31pm 14 June 2024