Undefined variable 'arg' in core/modules/views/src/Plugin/views/argument_validator/None.php

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

@quietone thanks for uploading a tests-only patch so can see that the fix indeed does work.

The change made looks good. Agree checking if the number is_numeric makes all the sense in the world haha.

However, I would have expected that a numeric argument would have the Numeric validator, not the None validator. Perhaps that is the underlying problem?

I think that the None validator is used for literally everything, when no argument validation is set. So the problem is that without this code it would cause issues with the numeric validator. I think really it should not have to know which argument it's dealing with - i.e. why is it doing any validation at all if validation is set to none?

Re-titling since the undefined variable was dealt with elsewhere already.

I think we should open a follow-up for #72 - i.e. can we move plugin-specific code out of the None validator or at least better document why it's there.

Opened 📌 Re-evaluate numeric validator Postponed: needs info

Convert to MR and updated it for the latest comments.

feedback appears to be addressed

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebased.

We need to update the issue summary. I think we need to consider the correctness of the code and what it should be doing. Also the issue summary is incorrect - there's no PHP notice about an undefined variable anymore.

I've tried to work out why but unfortunately this code was added to views before the great CVS migration so it is seriously old code.

For me the big question here is why do we have this code at all. My guess is that if the argument is numeric then this is some very basic validation we can do. We should have a comment that indicates this in the None plugin.