- First commit to issue fork.
- 🇺🇸United States phenaproxima Massachusetts
This breaks recipes that use Pathauto, which is many recipes in Starshot. Therefore, tagging this as part of those initiatives.
The fix looks correct to me, so RTBC on the assumption that tests will pass.
- @mandclu opened merge request.
- 🇦🇺Australia pameeela
I created a child issue to discuss the 'basic' event recipe scope: #3463884: Define scope of 'basic' event recipe that would be offered in the installer →
I think we'll want child issues for individual topics just so we can follow the threads.
- 🇨🇦Canada mandclu
@matthieuscarset I would love to consider Calendar View for use in Starshot, though I do have concerns that it doesn't yet have a Drupal 11-ready release. I would say that would be a top priority for a dialog about inclusion in Starshot.
One other potential consideration: Fullcalendar View offers drag-and-drop rescheduling of events by day, by hour, or even of the length of the event. If Calendar View can offer all of this it would significantly narrow the field.
I'd like to help contributing to this track with a focus on the Calendar display. I suggest to use the Calendar View → which is compatible with core and
smart_date
but it needs work to improve the display of complex events (i.e. events spanning on several days, display as day with hours or agenda list...etc).This track is an opportunity to improve this module and vice-versa!
- 🇺🇸United States thejimbirch Cape Cod, Massachusetts
I have applied to lead this track.
- 🇮🇳India Akhil Babu Chengannur
Added a Kernel test for the example recipe as suggested in #24. Also updated simple_config_update to simpleConfigUpdate in the example recipe.
- 🇮🇳India Akhil Babu Chengannur
Akhil Babu → made their first commit to this issue’s fork.
- Issue created by @phenaproxima
- 🇦🇺Australia pameeela
@drupal a11y just replying here too in case others have the same question, you can make a new submission just noting it's updated and we'll make sure to combine them.
- 🇩🇪Germany A11y_Expert Nuremberg Area
@pameeela: I applied but would need to update the information. Is there any option I could do this?
- 🇩🇪Germany breidert
In our preconfigured CMS we use the following contrib modules for SEO:
- https://www.drupal.org/project/schema_metatag →
- https://www.drupal.org/project/metatag →
- https://www.drupal.org/project/simple_sitemap →
We have the following modules enabled and configured out-of-the-box to go with the entity types we provide:
- drupal/metatag_dc
- drupal/metatag_dc
- drupal/metatag_open_graph
- drupal/metatag_views
- drupal/schema_metatag
- drupal/schema_article
- drupal/schema_organization
- drupal/simple_sitemap
Apart from providing information to search engine large parts are about the performance of the site in general.
This includes
- forcing editors to provide sensible data (like real alternative texts for images) for all content created,
- providing accessible HTML for screen readers,
- minimal HTML, CSS, JS for performance,
and much more.
For the above there are no modules you can install, but it is a mixture of good configuration of the editorial UIs and solid frontend engineering.
For accessibility we provide editors with the nice module https://www.drupal.org/project/editoria11y → .
- Issue created by @phenaproxima
-
alexpott →
committed d9a1ec2d on 11.x
Issue #3303127 by phenaproxima, thejimbirch, alexpott, Wim Leers, nedjo...
-
alexpott →
committed d9a1ec2d on 11.x
- 🇺🇸United States thejimbirch Cape Cod, Massachusetts
Tests pass and feedback addressed. Marking as RTBC.
- 🇺🇸United States phenaproxima Massachusetts
✨ Create flexible config actions to place a block in the admin or default themes Needs review allows
position: first
andposition: last
, but not ordinal positions. IMHO that would be nice to have. - 🇬🇧United Kingdom alexpott 🇪🇺🌍
I think we need to apply some validation to the name parameter... let's make it a valid PHP function name. Excludes things like unicode and means it has to start with a letter which will be good for yaml keying.
We should add test coverage for the attribute name validation to core/tests/Drupal/Tests/Core/Config/Action
- 🇺🇸United States phenaproxima Massachusetts
This got committed in ✨ Create flexible config actions to place a block in the admin or default themes Needs review , so I think we can close this issue!
- 🇺🇸United States phenaproxima Massachusetts
Fixed @alexpott's feedback. Since it was literally just renaming a parameter, I don't think we need to shuffle through the whole needs review process for this. Restoring RTBC.
-
alexpott →
committed fbc03520 on 11.x
Issue #3448131 by mandclu, phenaproxima, ultrabob, immaculatexavier,...
-
alexpott →
committed fbc03520 on 11.x
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Crediting @thejimbirch - thanks for the initial work on this one!
- 🇮🇳India guptahemant
Interested in leading and helping with this track. Submitted the proposal
- 🇮🇳India guptahemant
Interested in leading and helping with this track. Submitted the proposal
- 🇬🇧United Kingdom catch
Note that workspaces module is stable in core as of 10.3.0.
- 🇬🇧United Kingdom catch
Note that the xmlsitemap module itself has a lot of performance issues, and momentum seems to be moving to https://www.drupal.org/project/simple_sitemap → instead.
Simple sitemap has 120k modern Drupal installs, vs 60k for xmlsitemap.
I haven't used either module recently, but posting this based on discussions with multiple people who have.
- 🇨🇦Canada b_sharpe
Tests are passing, Confirmed aliasing works as expected, noted other concerns, all others addressed. Looks great!
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇺🇸United States phenaproxima Massachusetts
Updating the issue summary with an partial list of every action added by this merge request, with examples for documentation.
-
alexpott →
committed 1c218641 on 11.x
Issue #3379725 by Wim Leers, phenaproxima, narendraR, alexpott, quietone...
-
alexpott →
committed 1c218641 on 11.x
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed 1c21864 and pushed to 11.x. Thanks!
Given where we are at in the 11.0.0 release cycle we can't commit this to 11.0.0 and have to target 11.1.0 instead. I've updated the deprecation messages and tests on commit.
diff --git a/core/modules/block/src/Entity/Block.php b/core/modules/block/src/Entity/Block.php index 2effc409b7..68582e48f0 100644 --- a/core/modules/block/src/Entity/Block.php +++ b/core/modules/block/src/Entity/Block.php @@ -349,7 +349,7 @@ public function preSave(EntityStorageInterface $storage) { parent::preSave($storage); if (!is_int($this->weight)) { - @trigger_error('Saving a block with a non-integer weight is deprecated in drupal:11.0.0 and removed in drupal:12.0.0. See https://www.drupal.org/node/3462474', E_USER_DEPRECATED); + @trigger_error('Saving a block with a non-integer weight is deprecated in drupal:11.1.0 and removed in drupal:12.0.0. See https://www.drupal.org/node/3462474', E_USER_DEPRECATED); $this->setWeight((int) $this->weight); } diff --git a/core/modules/block/tests/src/Kernel/BlockValidationTest.php b/core/modules/block/tests/src/Kernel/BlockValidationTest.php index 9a1a2412d6..2456e7fb57 100644 --- a/core/modules/block/tests/src/Kernel/BlockValidationTest.php +++ b/core/modules/block/tests/src/Kernel/BlockValidationTest.php @@ -176,7 +176,7 @@ public function testWeightValidation(): void { public function testWeightCannotBeNull(): void { $this->entity->set('weight', NULL); $this->assertNull($this->entity->getWeight()); - $this->expectDeprecation('Saving a block with a non-integer weight is deprecated in drupal:11.0.0 and removed in drupal:12.0.0. See https://www.drupal.org/node/3462474'); + $this->expectDeprecation('Saving a block with a non-integer weight is deprecated in drupal:11.1.0 and removed in drupal:12.0.0. See https://www.drupal.org/node/3462474'); $this->entity->save(); } diff --git a/core/modules/search/search.module b/core/modules/search/search.module index 8d5b1e330d..0944c53dcf 100644 --- a/core/modules/search/search.module +++ b/core/modules/search/search.module @@ -428,7 +428,7 @@ function search_block_presave(BlockInterface $block) { if ($block->getPluginId() === 'search_form_block') { $settings = $block->get('settings'); if ($settings['page_id'] === '') { - @trigger_error('Saving a search block with an empty page ID is deprecated in drupal:11.0.0 and removed in drupal:12.0.0. To use the default search page, use NULL. See https://www.drupal.org/node/3463132', E_USER_DEPRECATED); + @trigger_error('Saving a search block with an empty page ID is deprecated in drupal:11.1.0 and removed in drupal:12.0.0. To use the default search page, use NULL. See https://www.drupal.org/node/3463132', E_USER_DEPRECATED); $settings['page_id'] = NULL; $block->set('settings', $settings); }
- 🇧🇪Belgium borisson_ Mechelen, 🇧🇪
I reviewed it again today as well, and the one remark I had was answered. RTBC++
- 🇺🇸United States phenaproxima Massachusetts
Okay, I agree with you @tim.plunkett; did the deprecation dance around page_id and added a change record.
The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇺🇸United States phenaproxima Massachusetts
Assigning to myself to do some cleanup here.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
This is looking great - love the work @mandclu and @phenaproxima are doing.
Posted some comments on the MR - most of which are are tiny nits.
- 🇬🇧United Kingdom catch
Committed/pushed to 11.1.x, thanks!
If we want to add this to 10.4.x, it'll need a separate MR, but marking fixed for now.
- 🇨🇦Canada mandclu
After looking at the code some more, I realized that the above was a problem with the recipe using the
weight
key instead of the intendedposition
key. With the updated recipe the blocks were placed as expected and the weight assigned the expected numerical values, for both 'first' and 'last'. - 🇨🇦Canada mandclu
I tested the new config actions by applying a recipes with this in the recipe.yml file:
name: 'Place blocks' config: actions: block.block.powered_first: placeBlockInDefaultTheme: id: powered_first region: olivero: content weight: first plugin: system_powered_by_block block.block.powered_first_admin: placeBlockInAdminTheme: id: powered_last theme: admin region: claro: content weight: first plugin: system_powered_by_block
Both blocks were placed, but ended up with zero as the weight, so were not placed before existing blocks.
- 🇦🇹Austria drunken monkey Vienna, Austria
Thanks a lot for this suggestion, @phenaproxima, I was not aware of this addition to Drupal core, and thanks a lot, @narendraR, for already providing the necessary code and even a test!
Even though we don’t require Drupal 10.3 at the moment, it should probably be harmless to add this class already now since I suspect it will just be ignored as long as theConfigAction
plugin type is unknown. (I temporarily enabled testing against all supported Drupal versions, just to be on the safe side.)However, could you maybe link some documentation resources regarding recipes and config actions? Currently I can just guess on whether this is all supposed to work like this based on your code.
Finally, I made some style changes to the MR, but nothing functional – that all seemed in order, as far as I understood it.
So, thanks again! If you are happy with my changes (and the test bot is, too), I will merge this. - 🇦🇹Austria drunken monkey Vienna, Austria
drunken monkey → made their first commit to this issue’s fork.