- Issue created by @phenaproxima
- ๐ฎ๐ณIndia Akhil Babu Chengannur
akhil babu โ made their first commit to this issueโs fork.
- Merge request !9419Issues/3463355: Add config action to remove effects from image styles. โ (Open) created by Akhil Babu
- ๐ฎ๐ณIndia Akhil Babu Chengannur
Image effects have only uuids. So to remove an effect, we should pass it's uuid to the config action.
I created a config action 'deleteImageEffect' which accepts the uuid of the effect to be removed, as a starting point. Moving this to 'needs review' for feedback. Haven't added any tests for now.config: actions: image.style.large: deleteImageEffect: 62f7b707-a0cc-459b-a8ee-1dd3eeb9b445
- Status changed to Needs review
7 months ago 6:08am 5 September 2024 - Status changed to Needs work
7 months ago 1:25pm 5 September 2024 - ๐บ๐ธUnited States smustgrave
Seems like a feature that needs test coverage
- ๐บ๐ธUnited States phenaproxima Massachusetts
I'd advise holding off on this issue. I haven't even yet been able to convince @alexpott that it's a good idea, which makes sense -- recipes have an intentionally extremely limited ability to undo or remove things, so if we're going to do this for image styles, we'll want to think through the use cases for it.
Personally I think it's justified, but without @alexpott's buy-in I'm not sure we'll get very far.
- ๐บ๐ธUnited States jcandan
I got here from โจ Add config actions to delete config Active . Even though I need this ability right now, I can completely agree with the idea of not including it.
The reason I need it is that we are firing up Recipes to run a bunch of automations for our turn-key websites. These automations fire off when one of our special themes is enabled.
However, Recipes introduces a new way of attacking our automations from scratch. We'll not need to provide the initial version of the site to then need to be overridden. We'll simply provide the right set of recipes from the get-go.
While I could see a use-case for this in a contrib module, perhaps this should not be included in core.
- ๐บ๐ธUnited States thejimbirch Cape Cod, Massachusetts
Hard coding a UUID in a recipe seems like a very narrow use case. Why not provide a new image style?
With that being said, I could see the need for replacing, or adding effects to image style config entities.