- Issue created by @phenaproxima
- ๐ฎ๐ณIndia Akhil Babu Chengannur
akhil babu โ made their first commit to this issueโs fork.
- Merge request !9419Issues/3463355: Add config action to remove effects from image styles. โ (Open) created by Akhil Babu
- ๐ฎ๐ณIndia Akhil Babu Chengannur
Image effects have only uuids. So to remove an effect, we should pass it's uuid to the config action.
I created a config action 'deleteImageEffect' which accepts the uuid of the effect to be removed, as a starting point. Moving this to 'needs review' for feedback. Haven't added any tests for now.config: actions: image.style.large: deleteImageEffect: 62f7b707-a0cc-459b-a8ee-1dd3eeb9b445
- Status changed to Needs review
8 days ago 6:08am 5 September 2024 - Status changed to Needs work
8 days ago 1:25pm 5 September 2024 - ๐บ๐ธUnited States smustgrave
Seems like a feature that needs test coverage
- ๐บ๐ธUnited States phenaproxima Massachusetts
I'd advise holding off on this issue. I haven't even yet been able to convince @alexpott that it's a good idea, which makes sense -- recipes have an intentionally extremely limited ability to undo or remove things, so if we're going to do this for image styles, we'll want to think through the use cases for it.
Personally I think it's justified, but without @alexpott's buy-in I'm not sure we'll get very far.