Add a config action to remove effects from image styles

Created on 23 July 2024, 9 months ago

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

โœจ Feature request
Status

Active

Version

11.0 ๐Ÿ”ฅ

Component
Image systemย  โ†’

Last updated 9 days ago

Created by

๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @phenaproxima
  • ๐Ÿ‡ณ๐Ÿ‡ฟNew Zealand quietone
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Akhil Babu Chengannur

    akhil babu โ†’ made their first commit to this issueโ€™s fork.

  • Pipeline finished with Canceled
    7 months ago
    #274308
  • Pipeline finished with Failed
    7 months ago
    Total: 126s
    #274310
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Akhil Babu Chengannur

    Image effects have only uuids. So to remove an effect, we should pass it's uuid to the config action.
    I created a config action 'deleteImageEffect' which accepts the uuid of the effect to be removed, as a starting point. Moving this to 'needs review' for feedback. Haven't added any tests for now.

    config:
      actions:
        image.style.large:
          deleteImageEffect: 62f7b707-a0cc-459b-a8ee-1dd3eeb9b445
    
  • Status changed to Needs review 7 months ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Akhil Babu Chengannur
  • Pipeline finished with Failed
    7 months ago
    #274323
  • Status changed to Needs work 7 months ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

    Seems like a feature that needs test coverage

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States phenaproxima Massachusetts

    I'd advise holding off on this issue. I haven't even yet been able to convince @alexpott that it's a good idea, which makes sense -- recipes have an intentionally extremely limited ability to undo or remove things, so if we're going to do this for image styles, we'll want to think through the use cases for it.

    Personally I think it's justified, but without @alexpott's buy-in I'm not sure we'll get very far.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States jcandan

    I got here from โœจ Add config actions to delete config Active . Even though I need this ability right now, I can completely agree with the idea of not including it.

    The reason I need it is that we are firing up Recipes to run a bunch of automations for our turn-key websites. These automations fire off when one of our special themes is enabled.

    However, Recipes introduces a new way of attacking our automations from scratch. We'll not need to provide the initial version of the site to then need to be overridden. We'll simply provide the right set of recipes from the get-go.

    While I could see a use-case for this in a contrib module, perhaps this should not be included in core.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States thejimbirch Cape Cod, Massachusetts

    Hard coding a UUID in a recipe seems like a very narrow use case. Why not provide a new image style?

    With that being said, I could see the need for replacing, or adding effects to image style config entities.

Production build 0.71.5 2024