- Issue created by @phenaproxima
- πΊπΈUnited States phenaproxima Massachusetts
This won't need explicitly test coverage, because it's just opting into (or out of) existing core APIs which are tested separately.
As of this comment, the proposed changes involve relaxing nearly every core recipes' comparisons with existing config. In general I think this is safe, and will more or less align with what recipe consumers expect (if I reapply it, my existing config will not be touched, unless I force-apply, which is not yet supported).
Field storages, I think, should almost always be treated strictly since they influence the database layout and how field instances are treated by the rest of the system. It seems unsafe to be lenient with a field_image field storage that you expect to be an image field, since some weirdo site builder could have a text field called field_image, which would be a completely different animal to be dealing with and fundamentally changes what the recipe could do with instances of that field.
Field instances probably don't need to be treated strictly because they are tightly coupled to the field storages, and I don't think the field type could differ from the field storage type (at least not without causing the most nightmarish and destructive of bugs -- if such a discrepancy is even possible).
-
alexpott β
committed 0c7224ab on 10.4.x
Issue #3481751 by phenaproxima, thejimbirch: Opt some core recipes out...
-
alexpott β
committed 0c7224ab on 10.4.x
-
alexpott β
committed d177974f on 11.x
Issue #3481751 by phenaproxima, thejimbirch: Opt some core recipes out...
-
alexpott β
committed d177974f on 11.x
- π¬π§United Kingdom alexpott πͺπΊπ
Committed and pushed d177974f854 to 11.x and 0c7224ab46e to 10.4.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.