RecipeCommand mistakenly tries to apply a recipe even if you don't give it a valid directory

I think we can just return a non zero int instead of throwing

Sure, that works too! Done.

This looks good, but I'm not sure the test is actually working.

For some reason I can't run the test only job, but I pulled the branch down to run it without the return and the tests still pass.

It took a bit of effort due to the phpunit 10 update, but I needed to handle that eventually.

If someone that has permission can run the test only job that might confirm my local findings.

I think the claim that

The problem is that...it outputs the error, then continues executing! This leads to buggy behavior.

Is actually incorrect. What happens now is that an exception is thrown when we call $recipe = Recipe::createFromDirectory($recipe_path);... there's no buggy behaviour at all. The exception comes from \Drupal\Core\Recipe\Recipe::parse() so very early on. And the exception message is accurate too.

FWIW the test now fails when run without the fix. https://git.drupalcode.org/project/drupal/-/jobs/1598345

Looks good now!

Committed to 11.x, backported to 11.0.x, 10.4.x and 10.3.x

larowlan → closed merge request !8069

Added this to the 10.3.0-rc1 and 11.0.0-beta2 release notes drafts, since we're treating Recipes as stable-ish internal API rather than experimental, so fixing things broken with it before the stable releases is valuable info to early testers.

Automatically closed - issue fixed for 2 weeks with no activity.