- Issue created by @jnicola
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
What you are describing is exactly what Project Browser integration is envisioned to do.
- πΊπΈUnited States jnicola
As I understand it, project browser will allow seeing ALL recipes out there.
I envision recipes needs an equivalent to "extend" (/admin/modules) so you can see what revisions you have locally already and apply them if you wish to.
Or will project browser allow you to filter based on what you have locally?
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
It's a good question. I edited my post immediately after I submitted it. I would think that Project Browser could list local recipes, but I don't know if that is reality or not.
- πΊπΈUnited States jnicola
I just chatted with those folks since they're a table over here at DrupalconPDX.
Per the table:
-With modules if you have the module locally it will display that you have it, and display whether it is installed or not, and if not installed provide you the option to install.
-"The more forward thinking way would be to build this in project browser".I think as a potential interim though, it wouldn't be the worst idea to build this.
I say we do a UI module to get us by for now, while another issue tackles project browser integration.
- πΊπΈUnited States jnicola
Okay so working with @maskedjellybean on this today, we were able to create a working UI. The patch is attached, and yes a fork is better but this isn't actually a core issue yet and (insert drupal procedure stuff her)
We expanded RecipeDiscovery to have the same methods as core Extensiondiscovery, and then got them working to find available recipes in core, provide a list of all recipes in core that don't throw exceptions when loading the Recipe object for that Recipe, and then allow users to select recipes, which on form submit are applied.
It does work! ... we just navigate the whole Drupal core rigamarole of moving this to core, but can it even be core, should we even do this because project browser is someday doing this, even if we can have this now instead of later... etc etc.
- πΊπΈUnited States jnicola
It should be noted, this would be an early alpha, it can be expanded, but the form is there, you can submit and things apply, and an array of all Recipes that don't throw exceptions is there so if the UI is to be improved, it surely can be!
- πΊπΈUnited States jnicola
Oh and another bit... the Example recipe fails to load and throws an exception. We had to remove it to make this work.
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Created a merge request from @jnicola's patch.
- πΊπΈUnited States jnicola
@jimburch I think this is actually on hold and may not even happen at all unfortunately.
The main push apparently is for this all to exist in project browser. No idea how far out that getting brought into core is.
I also opened a ticket for the new DiscoveryClass, which I included in here but has changed some, etc etc.
https://www.drupal.org/project/drupal/issues/3446354 β¨ Expand Drupal\Core\Recipe\RecipeDiscovery to allow discovering available recipes, likely for use in Project Browser ActiveRecipe discover also needs a bit of time since we need to move validation from Recipe creation to it's own stand alone method.
https://www.drupal.org/project/drupal/issues/3446329 π Recipes' ConfigConfigurator should not immediately check for conflicts with active config Active - Status changed to Postponed
7 months ago 7:23pm 17 May 2024 - Status changed to Active
6 months ago 1:57pm 11 June 2024 - πΊπΈUnited States jnicola
I see this was reopened ... are we doing this or not?
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
Its not in our Phase 2 roadmap. Looks like Wim opened it to add [PP-2] to the title, which is Postponed on 2 issues.
- Status changed to Postponed
6 months ago 10:33am 14 June 2024