- Issue created by @thejimbirch
- πΊπΈUnited States phenaproxima Massachusetts
Added a test - that was easy! This is good to go.
- πΊπΈUnited States phenaproxima Massachusetts
From a UX perspective, I have a doubt here. I agree with @thejimbirch about this:
in most cases, you will only want a single instance.
In light of that, maybe it would make more sense to invert the logic here and to make skip-if-exists the default behavior, with an
allow_duplicate: true
flag to override that.Thoughts?
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
I tested and it works as is, but I do feel like this would be the more normal behavior:
skip-if-exists the default behavior, with an allow_duplicate: true flag to override
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
That works also as expected. This is much better behavior to not duplicate by default.
-
larowlan β
committed c1927736 on 11.x
Issue #3479411 by phenaproxima, thejimbirch: The addItemToToolbar config...
-
larowlan β
committed c1927736 on 11.x
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Committed to 11.x - thanks!
- πΊπΈUnited States phenaproxima Massachusetts
Could this be backported to 10.4.x? Recipes are still experimental, and this would be quite helpful to Starshot.
-
larowlan β
committed 5ad1219b on 10.4.x
Issue #3479411 by phenaproxima, thejimbirch: The addItemToToolbar config...
-
larowlan β
committed 5ad1219b on 10.4.x
-
larowlan β
committed cba026ef on 10.5.x
Issue #3479411 by phenaproxima, thejimbirch: The addItemToToolbar config...
-
larowlan β
committed cba026ef on 10.5.x
-
larowlan β
committed cdf352a4 on 11.1.x
Issue #3479411 by phenaproxima, thejimbirch: The addItemToToolbar config...
-
larowlan β
committed cdf352a4 on 11.1.x
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Backported to 11.1.x, 10.5.x and 10.4.x
Automatically closed - issue fixed for 2 weeks with no activity.