- Issue created by @phenaproxima
- πΊπΈUnited States phenaproxima Massachusetts
phenaproxima β changed the visibility of the branch 3495305-test-only to hidden.
- πΊπΈUnited States phenaproxima Massachusetts
This is ready for review and has failing test coverage.
- πΊπΈUnited States phenaproxima Massachusetts
Tests are failing as expected: https://git.drupalcode.org/issue/drupal-3495305/-/jobs/3776754#L54
- πΊπΈUnited States phenaproxima Massachusetts
Project Browser can work around this problem (by prying open the static cache with reflection and clearing it), so this is not a stable blocker for Drupal CMS.
But it is a legitimate bug that needs to be fixed. :)
- πΊπΈUnited States tim.plunkett Philadelphia
This makes a lot of sense, some real fun nuance in there with
- private ?array $values = NULL; + private array $values = [];
:D
-
alexpott β
committed 379ebd46 on 11.1.x
Issue #3495305 by phenaproxima: Recipes that depend on other recipes...
-
alexpott β
committed 379ebd46 on 11.1.x
-
alexpott β
committed ac347da7 on 11.x
Issue #3495305 by phenaproxima: Recipes that depend on other recipes...
-
alexpott β
committed ac347da7 on 11.x
- π¬π§United Kingdom alexpott πͺπΊπ
Committed and pushed ac347da742f to 11.x and 379ebd46fcc to 11.1.x. Thanks!
We could backport this 10.4.x and 10.5.x if we choose.
- πΊπΈUnited States phenaproxima Massachusetts
I don't think there's any real harm in backporting it, but also not much value (yet) beyond keeping it consistent, since
RecipeInputFormTrait
only appeared in 11.1. Automatically closed - issue fixed for 2 weeks with no activity.