Project Browser's routes should allow project IDs to contain dashes

🤔 Shouldn't there be per-source plugin (see ✨ Expand Package Manager integration to support other source plugins Active for general infra and ✨ Create a source plugin that scans for locally installed recipes Active for the infra relating to @phenaproxima's proposed MR here) routes?

Because the current restrictions are fine for Drupal.org-hosted Drupal extensions. Recipes being a new kind of source, with its own semantics, seems like it would merit its own routes, with different restrictions? 🤔

The sources shouldn't be responsible for the routes. The routes are how the front-end communicates with the back-end, and none of that is source-specific. The sources are really just meant, as far as I can tell, to provide metadata on the projects available.

Making sources even partially responsible for routing would likely represent a big increase in complexity and possibility for bugs. The semantics really aren't different, IMHO; you're telling Project Browser which package you want to install and "activate". It's the same meaning.

👍 Sounds sensible!

(I know nothing about Project Browser's architecture. But this change does represent a widening of accepted inputs, and hence has some security implication.)

Unfortunately, I don't see how this can land without tests passing, but tests stopped passing 4 days ago: https://www.drupal.org/pift-ci-job/2836340 → . That needs to be fixed first, but no issue for it exists yet? 😅

There is now: 🐛 Tests are failing Active

🐛 Tests are failing Active is in!

Oops, let's re-trigger tests — didn't realize this was not yet on GitLab CI so I can't easily re-trigger the pipeline 😅

Let's rebase this to trigger a new test?

Restoring RTBC on the assumption that this'll pass...

It did! 🚀

Pretty straightforward change. Merged!

Automatically closed - issue fixed for 2 weeks with no activity.