Improve PluginNotFound exception to include possible shorthand action IDs

akhil babu → made their first commit to this issue’s fork.

akhil babu → changed the visibility of the branch 3302833-imporve-exception to hidden.

I tried to create an MR for this, but I am not able to rebase it properly
These are the changes: https://git.drupalcode.org/project/distributions_recipes/-/merge_request...

akhil babu → changed the visibility of the branch 11.x to hidden.

akhil babu → changed the visibility of the branch 11.x-1 to hidden.

akhil babu → changed the visibility of the branch 3302833-imporve-exception-2 to hidden.

These are the changes

b_sharpe → changed the visibility of the branch 3302833-imporve-exception-3 to hidden.

b_sharpe → changed the visibility of the branch 3302833-improve-pluginnotfound-exception to hidden.

There are still a lot of conflicts that need rebase. Can we create a new branch and add changes to that?

@Prashant.c where are the conflicts? The fork is 1 commit ahead of upstream... Please provide more details.

@b_sharpe

Yes, I was checking on Drupal core 11.x, now checked on the recipes project code itself and it is up-to-date, no rebase needed.

The changes look good to me. Thanks

It'd be great if this had test coverage. Also I think this issue can be made against drupal/core and not the recipes initiative as the code is in core.

Added the tests.

Also I think this issue can be made against drupal/core and not the recipes initiative as the code is in core.

Not sure how to do it. Create a new issue against Drupal core and close this one?

I am changing the issue to be against core.

I believe you will just need to open a new MR targeting core, not the recipes project.

akhil babu → changed the visibility of the branch 3302833-PluginNotFound to hidden.

Thanks @thejimbirch. I have opened a new MR against core

Updated the test to validate the config action names.

Left a small comment on the MR.

Thanks @smustgrave. Alexpott added a comment in the MR to add a test to verify the valid config actions. Drupal\Core\Config\Action\ConfigActionManager::getShorthandActionIdsForEntityType gives the list of shorthand actions per entity type, but this method is protected. So @alexpot suggested to hardcode the exception message.
https://drupal.slack.com/archives/C1BMUQ9U6/p1724325139885199

@akhil babu I believe it is a question of changing the assertion itself. You can still 'hard coding' text in the (new) assertion and follow the advice of @alex pott by not using a Reflection method if you follow #27

smustgrave → changed the visibility of the branch 3302833-improve-pluginnotfound-exception to hidden.

Hiding 9274

The MRs were relatively the same but 9274 was checking the current config action list at this point in time. 9411 checks the start of the exception without verifying the full list. The test was meant to just test the exception.

But believe feedback has been addressed.

The one failed test run seems unrelated https://git.drupalcode.org/issue/drupal-3302833/-/pipelines/273490

 Line   core/tests/Drupal/Tests/Core/Update/UpdateRegistryTest.php              
 ------ ------------------------------------------------------------------------ 
  244    Path in include_once()                                                  
         "vfs://drupal/sites/default/modules/module_a/module_a.post_update.php"  
         is not a file or it does not exist.                                     
  245    Path in include_once()                                                  
         "vfs://drupal/sites/default/modules/module_b/module_b.post_update.php"  
         is not a file or it does not exist.         

Backported to 10.3.x as this is helpful.

Committed e9461d7 and pushed to 11.x. Thanks!
Committed and pushed e573df5fd0 to 11.0.x and 7bf317d4c4 to 10.4.x and 5fe48edb3b to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.