- Issue created by @phenaproxima
- First commit to issue fork.
- Status changed to Needs review
2 months ago 6:40am 26 June 2024 - ๐ฆ๐นAustria drunken monkey Vienna, Austria
drunken monkey โ made their first commit to this issueโs fork.
- ๐ฆ๐นAustria drunken monkey Vienna, Austria
Thanks a lot for this suggestion, @phenaproxima, I was not aware of this addition to Drupal core, and thanks a lot, @narendraR, for already providing the necessary code and even a test!
Even though we donโt require Drupal 10.3 at the moment, it should probably be harmless to add this class already now since I suspect it will just be ignored as long as theConfigAction
plugin type is unknown. (I temporarily enabled testing against all supported Drupal versions, just to be on the safe side.)However, could you maybe link some documentation resources regarding recipes and config actions? Currently I can just guess on whether this is all supposed to work like this based on your code.
Finally, I made some style changes to the MR, but nothing functional โ that all seemed in order, as far as I understood it.
So, thanks again! If you are happy with my changes (and the test bot is, too), I will merge this. - ๐ฆ๐นAustria drunken monkey Vienna, Austria
@phenaproxima/@narendraR: Please give the latest version of the MR a try and tell me what you think.
Also, would still appreciate links to some documentation. - ๐ฎ๐ณIndia narendraR Jaipur, India
Re #7,
Changes looks good to me.https://git.drupalcode.org/project/distributions_recipes/-/blob/1.0.x/docs/config_actions.md has some details regarding config actions.
- Status changed to Fixed
29 days ago 12:33pm 10 August 2024 - ๐ฆ๐นAustria drunken monkey Vienna, Austria
@narendrar: Thanks for reporting back, good to hear the changes look OK to you.
Also thanks for the docs link, that cleared up things a bit more! (Although this, too, seems outdated and/or incomplete, as it only discusses theActionMethod
attribute, notConfigAction
.)Anyways, merged. Thanks again!
-
drunken monkey โ
committed 056ba2cb on 8.x-1.x authored by
narendrar โ
Issue #3456728 by narendrar, drunken monkey: Added a config action for...
-
drunken monkey โ
committed 056ba2cb on 8.x-1.x authored by
narendrar โ
Automatically closed - issue fixed for 2 weeks with no activity.