- Issue created by @phenaproxima
- πΊπΈUnited States phenaproxima Massachusetts
I discussed this with @alexpott in Zoom today.
Long story short: this issue can proceed as it currently exists, but there needs to be a longer-term plan to unify the messy solar system that consists of Typed Data, config schema, the form system, and CLI input. Drupal doesn't have a single generalized "data input, validation, and translation system" that we could leverage, really. The recipe system leverages Typed Data in a reasonably pure way, but as the current patch demonstrates, that necessitates encoding form API elements into recipes if we want them to be presented in a particular way in a particular context. It would be so much better if I could just say "this input is a string with these validation constraints", and trust that Drupal would be able to present that input appropriately in the CLI, in a form, etc.
But we're a long way off from that.
So we decided to be pragmatic as ever, and implement the proposed approach. Hopefully we can deprecate it as core's ability to handle input in a unified way becomes more robust. But for now, this is the clearest way for us to deliver this essential feature.
- π¬π§United Kingdom alexpott πͺπΊπ
We also need to deal with recipe translation. We should see if there is an issue and if not open one. It's going to be complex.
- πΊπΈUnited States phenaproxima Massachusetts
Filed β¨ Make recipes translatable Active to deal with recipe translation.
- πΊπΈUnited States tim.plunkett Philadelphia
Given that β¨ [PP-1] Give recipes a way to group and organize their inputs, when they are presented in a form Postponed exists, I think this is a pretty nice way of handling this. Great work!
- πΊπΈUnited States phenaproxima Massachusetts
Made an attempt at a change record: https://www.drupal.org/node/3489030 β
- πΊπΈUnited States phenaproxima Massachusetts
Whoops. Nope, we're still RTBC.
- πΊπΈUnited States thejimbirch Cape Cod, Massachusetts
+1 for RTBC
Best we've got on the Forms API elements
https://www.drupal.org/docs/drupal-apis/form-api/form-render-elements#s-... β - π¬π§United Kingdom alexpott πͺπΊπ
Committed and pushed 8b67272ac33 to 11.x and cc885723370 to 11.1.x and 0e4ae7c20fe to 10.5.x and 45843c37585 to 10.4.x. Thanks!
-
alexpott β
committed 45843c37 on 10.4.x
Issue #3483435 by phenaproxima, alexpott, thejimbirch: Add a trait for...
-
alexpott β
committed 45843c37 on 10.4.x
-
alexpott β
committed 0e4ae7c2 on 10.5.x
Issue #3483435 by phenaproxima, alexpott, thejimbirch: Add a trait for...
-
alexpott β
committed 0e4ae7c2 on 10.5.x
-
alexpott β
committed cc885723 on 11.1.x
Issue #3483435 by phenaproxima, alexpott, thejimbirch: Add a trait for...
-
alexpott β
committed cc885723 on 11.1.x
-
alexpott β
committed 8b67272a on 11.x
Issue #3483435 by phenaproxima, alexpott, thejimbirch: Add a trait for...
-
alexpott β
committed 8b67272a on 11.x
-
alexpott β
committed 092a1819 on 10.5.x
Revert "Issue #3483435 by phenaproxima, alexpott, thejimbirch: Add a...
-
alexpott β
committed 092a1819 on 10.5.x
-
alexpott β
committed bcf6c4a0 on 10.4.x
Revert "Issue #3483435 by phenaproxima, alexpott, thejimbirch: Add a...
-
alexpott β
committed bcf6c4a0 on 10.4.x
- π¬π§United Kingdom alexpott πͺπΊπ
We need to change some of the constraints for the forms definition in the recipe for this to work on 10.x - reverted from there.
Automatically closed - issue fixed for 2 weeks with no activity.