-
drunken monkey โ
committed a7b566b0 on 8.x-1.x authored by
a.dmitriiev โ
Issue #3483366 by a.dmitriiev, drunken monkey, borisson_: Added a "...
-
drunken monkey โ
committed a7b566b0 on 8.x-1.x authored by
a.dmitriiev โ
- ๐ฆ๐นAustria drunken monkey Vienna, Austria
Great job. Merged!
Thanks again! - ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
We also need to deal with recipe translation. We should see if there is an issue and if not open one. It's going to be complex.
- ๐บ๐ธUnited States phenaproxima Massachusetts
I discussed this with @alexpott in Zoom today.
Long story short: this issue can proceed as it currently exists, but there needs to be a longer-term plan to unify the messy solar system that consists of Typed Data, config schema, the form system, and CLI input. Drupal doesn't have a single generalized "data input, validation, and translation system" that we could leverage, really. The recipe system leverages Typed Data in a reasonably pure way, but as the current patch demonstrates, that necessitates encoding form API elements into recipes if we want them to be presented in a particular way in a particular context. It would be so much better if I could just say "this input is a string with these validation constraints", and trust that Drupal would be able to present that input appropriately in the CLI, in a form, etc.
But we're a long way off from that.
So we decided to be pragmatic as ever, and implement the proposed approach. Hopefully we can deprecate it as core's ability to handle input in a unified way becomes more robust. But for now, this is the clearest way for us to deliver this essential feature.
- ๐ง๐ชBelgium borisson_ Mechelen, ๐ง๐ช
I think this is all the test coverage we need. Looks good to me.
- ๐ฎ๐ณIndia sagarmohite0031
Hello,
I am not able to reproduce the issue getting error while applying patch.
Please see the attachment. Hi,
I am not able to reproduce the issue before applying patch.
Please see the attachment.
NotReproduceable.png- ๐ฉ๐ชGermany a.dmitriiev
Updated patch for 1.35 to use in Drupal CMS search track recipe
- ๐บ๐ธUnited States thejimbirch Cape Cod, Massachusetts
Not postponed, both are related to the Drupal CMS Dashboard track.
-
mandclu โ
committed eae73e87 on 4.2.x
Issue #3399475 by mandclu, codebymikey, mark_fullmer: The Augmenter...
-
mandclu โ
committed eae73e87 on 4.2.x