views.view.redirect.yml and views.view.redirect_404.yml do not match Drupal's export

Created on 23 August 2024, 3 months ago
Updated 18 September 2024, 2 months ago

Problem/Motivation

views.view.redirect.yml and views.view.redirect_404.yml are different than what is exported from Drupal.

This is causing recipes to not be idempotent and fail on a subsequent application as the config has changed.

This change happened in Drupal core 10.3

🐛 Pager h4 causes accessibility flag on many pages Fixed

Steps to reproduce

Apply a recipe that imports redirect's config, and then re-apply the recipe.

You get the following error:

In ConfigConfigurator.php line 47:

  The configuration 'views.view.redirect' exists already and does not match the recipe'
  s configuration

Proposed resolution

Updates the config file

Remaining tasks

MR to follow

User interface changes

N/A

API changes

N/A

Data model changes

N/A

🐛 Bug report
Status

Needs work

Version

1.0

Component

Code

Created by

🇺🇸United States thejimbirch Cape Cod, Massachusetts

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @thejimbirch
  • 🇺🇸United States thejimbirch Cape Cod, Massachusetts
  • 🇺🇸United States thejimbirch Cape Cod, Massachusetts
  • Merge request !115Adds Pagination header option → (Open) created by thejimbirch
  • Status changed to Needs review 3 months ago
  • 🇺🇸United States thejimbirch Cape Cod, Massachusetts

    MR Added.

  • Issue was unassigned.
  • 🇺🇸United States thejimbirch Cape Cod, Massachusetts
  • Status changed to RTBC 3 months ago
  • 🇩🇪Germany tobiasb Berlin

    No brainer.

  • Pipeline finished with Failed
    3 months ago
    Total: 4089s
    #262902
  • 🇮🇳India ankitv18

    As per the issue description and gitlab pipeline failure for previous minor i.e D10.2.x ~~ I would strongly suggest to cut new major branch with minimum support of D10.3

    cc: @berdir

  • 🇧🇪Belgium BramDriesen Belgium 🇧🇪

    I don't really see the need for a new branch. 10.2 is already dropped from active support and will drop security support in a few months.

  • Status changed to Needs work 3 months ago
  • 🇨🇭Switzerland berdir Switzerland

    I'm not really willing to drop last minor testing, and even less so to to create a major new release because of a single new optional config key.

    I understand what recipe API is trying to do, but this feels like a adding quite some burden on maintainers just because core decides to add a new feature. What's redirect supposed to do when views adds another such key in the next minor? and another in the next? Release new minor/major versions every time that then need to be maintained?

    Maybe config schema should include a default value system, and missing values that match the default could be ignored somehow? Just thinking out loud.

  • Pipeline finished with Failed
    3 months ago
    Total: 178s
    #263476
  • 🇺🇸United States thejimbirch Cape Cod, Massachusetts

    Updating to add the view file in the Redirect 404 submodule.

  • 🇺🇸United States DamienMcKenna NH, USA

    While the tests fail, has anyone tested manually installing this change on a 10.2 site? I feel like this should be something that core handles better.

Production build 0.71.5 2024