In this commit we can simply replace the
role
to menu and the sub div's role tomenuitem
if we want the multiselect filter to behave like the other filters but the problem is that it focuses on the whole div instead of the checkbox.I am pushing the changes with the above suggestions but someone testing this might switch to prior commit to see another version of this MR.Re #23
Withvoiceover switched on
now all the things mentioned are resolved except5
which i am not sure whether we want to do that as the 2 elements are different in nature.
I have tested everything else on Safari and chrome and it works fine in these two browsers.It would be helpful if you can have a look at this once again @rkoller and verify the changes.
Marking it NR.- πΊπΈUnited States chrisfromredfin Portland, Maine
There will be more a11y fixes coming, but I aim to try to keep them as small and narrowly scoped as possible.
-
chrisfromredfin β
committed 3dca0573 on 2.0.x authored by
utkarsh_33 β
Issue #3489972 by utkarsh_33, chrisfromredfin, narendrar: Accessibility...
-
chrisfromredfin β
committed 3dca0573 on 2.0.x authored by
utkarsh_33 β