🇯🇴Jordan @mohammad-fayoumi

Amman
Account created on 6 August 2018, over 6 years ago
  • Senior Software Engineer at Vardot 
#

Merge Requests

Recent comments

🇯🇴Jordan mohammad-fayoumi Amman

The issue already fixed on the branch 1.0.x however not released yet.

Creating a new stable release for this issue

🇯🇴Jordan mohammad-fayoumi Amman

I've added a steps to configure the corresponding workflow and updating the README.md file format

🇯🇴Jordan mohammad-fayoumi Amman

I encountered this issue on Drupal 10.3.6 with the moderated_content_bulk_publish module version 3.0.0-beta12.
The suggested patch didn't resolve the problem for me. However, after updating specific workflow settings, it started working. I believe the issue is related to how the workflow maps the publish and unpublish states.

🇯🇴Jordan mohammad-fayoumi Amman

Creating a static patch file for the latest stable version 3.0.0-beta1

🇯🇴Jordan mohammad-fayoumi Amman

I've changed the pager ID to 2 in order to apply the condition in the following code:

function views_show_more_preprocess_views_show_more_pager(&$vars) {
  /** @var \Drupal\Core\Pager\PagerManagerInterface $pager_manager */
  $pager_manager = \Drupal::service('pager.manager');

  $element = $vars['element'];
  $parameters = $vars['parameters'];
  $pager = $pager_manager->getPager($element);
  if (!$pager) {
    return;
  }
  $current = $pager->getCurrentPage();
  $total = $pager->getTotalPages();
  $pager_classes = ['js-pager__items', 'pager__items', 'pager-show-more'];

  if ($current < ($total - 1)) {
    $options = [
      'query' => $pager_manager->getUpdatedParameters($parameters, $element, $current + 1),
    ];

    $vars['item'] = [
      'href' => Url::fromRoute('<none>', [], $options),
      'text' => $vars['options']['show_more_text'],
      'attributes' => [
        'title' => t('Go to next page'),
      ],
    ];
  }
  else {
    $pager_classes[] = 'pager-show-more-empty';
  }

  $vars['attributes'] = new Attribute([
    'class' => $pager_classes,
  ]);

  // This is based on the entire current query string. We need to ensure
  // cacheability is affected accordingly.
  $vars['#cache']['contexts'][] = 'url.query_args';

  $vars['heading_id'] = Html::getUniqueId('pagination-heading');
}

The reason I did this is because when printing the values of $current and ($total - 1), they would always display 0. By setting the pager ID to 2, I was able to ensure the condition works as expected.

🇯🇴Jordan mohammad-fayoumi Amman

I'm facing the same exact issue, I'll try to identify the source of the bug

🇯🇴Jordan mohammad-fayoumi Amman

Reroll #6 with the latest updates on 4.x

🇯🇴Jordan mohammad-fayoumi Amman

Update the patch according to the latest changes on 8.x-3.x

🇯🇴Jordan mohammad-fayoumi Amman

Reroll the MR !16 by creating a static patch file to work with the latest stable version 4.2.1

🇯🇴Jordan mohammad-fayoumi Amman

I have a taxonomy with machine name and once I visit it's the manage display I got the reported error.

The website encountered an unexpected error. Try again later.
Error: Call to a member function label() on null in _ds_field_ui_table_layouts() (line 903 of modules/contrib/ds/includes/field_ui.inc).

After some debugging I found this line return empty array.
$row = \Drupal::config($name)->get();

The issue appeared on visiting the default view mode.

🇯🇴Jordan mohammad-fayoumi Amman

Thank you @ressa and @rajan kumar for your contributions.
The module has now been officially updated and is supported with the release of version1.0.1.

🇯🇴Jordan mohammad-fayoumi Amman

I've encountered this issue with:

  • Drupal Version 10.3.2
  • PHP Version 8.2.23
🇯🇴Jordan mohammad-fayoumi Amman

I've encountered this issue and realized that we need to secure the cookies by ensuring our website is configured to use HTTPS, which involves having an SSL/TLS certificate installed. Additionally, the cookies should have the Secure attribute.

There are multiple ways to add these security flags, either by editing the application code (bigpipe code) or updating the web server configuration files, such as the Apache configuration file (httpd.conf or apache2.conf).

Apache configuration file (httpd.conf or apache2.conf).

<IfModule mod_headers.c>
    Header edit Set-Cookie ^(.*)$ $1;HttpOnly;Secure
</IfModule>
🇯🇴Jordan mohammad-fayoumi Amman

Thanks for the merge request.
After reviewing and testing it I found that this line of code $url = $this->view->hasUrl() ? $this->view->getUrl() : Url::fromRoute('<current>'); will always return views/ajax I see we have to get the current page path not the ajax request URL.

🇯🇴Jordan mohammad-fayoumi Amman

#6 AZ Glossary widget plugin should support ajax views Needs work works, but it's outdated. This patch will update it with the latest version.

🇯🇴Jordan mohammad-fayoumi Amman

This fix is crucial as it impacts the fundamental functionality of this module.

🇯🇴Jordan mohammad-fayoumi Amman

Mohammad-Fayoumi made their first commit to this issue’s fork.

🇯🇴Jordan mohammad-fayoumi Amman

I would like to bring to your attention that this issue appears to be critical within the module.
I was wondering if there have been any recent developments or updates regarding this matter?

🇯🇴Jordan mohammad-fayoumi Amman

Updated the previous patch #4 to trim the white spaces in CSV mentioned here.

White Space in exported CSV file 🐛 White Space in exported CSV file Needs review

🇯🇴Jordan mohammad-fayoumi Amman

@soumyajit40cs Thank you for submitting the patch. I appreciate your efforts.

I'd like to kindly mention that the changes must be also applied to the XLSX headers as well.

Additionally, I've made an update to the patch to include the decoding for the exported CSV files.

🇯🇴Jordan mohammad-fayoumi Amman

@quadrexdev Thanks,

The patch works as expected.

🇯🇴Jordan mohammad-fayoumi Amman

updating the patches and adopting a solution that assigns a default value to the string parameter before invoking mb_strtolower(). This approach ensures compatibility with PHP 8.1 and prevents passing null as the string parameter, which triggers the deprecation warning.

🇯🇴Jordan mohammad-fayoumi Amman

Mohammad-Fayoumi made their first commit to this issue’s fork.

🇯🇴Jordan mohammad-fayoumi Amman

Thanks for the patch.
A new release has been published 1.0.1

Production build 0.71.5 2024