- Issue created by @mlncn
- Status changed to Needs work
over 1 year ago 9:54pm 1 August 2023 - πΊπΈUnited States mlncn Minneapolis, MN, USA
Here is a patch that works around the problem. The requested value is still 'stored' as NULL for some reason, but this fallback substitutes the default FALSE in that case.
Whichever way a person selects the option to do it only for "selected translations" will be ignored, and it will be done for all translations of the selected content.
This is good enough for me, and maybe there should be different actions for "all translations" and "selected translations" to remove the annoying and not working anyway second selection page.
-
joseph.olstad β
committed c6bf2751 on 3.0.x authored by
mlncn β
Issue #3378586 by mlncn: Argument #3 ($currentTranslationOnly) must be...
-
joseph.olstad β
committed c6bf2751 on 3.0.x authored by
mlncn β
- Status changed to Fixed
over 1 year ago 10:09pm 1 August 2023 - Status changed to Needs work
over 1 year ago 11:01pm 1 August 2023 - πΊπΈUnited States mlncn Minneapolis, MN, USA
Thanks but what i did was definitely a workaround!! Not a fix! Also was coming back to post a patch that covers publish and unpublish. Still a workaround, does not address the configuration not being saved properly in intermediate step for use in final step.
- πΊπΈUnited States mlncn Minneapolis, MN, USA
This line:
$config = \Drupal::config('moderated_content_bulk_publish.settings');
would seem to be what's wrong?
The setting was done on the bulk operations form, not from the settings form (which does have a related setting that would be the appropriate fallback i guess, not my 'false', of
current_translation_only_default_value
).Again the easiest solution i can think of that might also improve user experience is to have unpublish_all_translations and unpublish_selected_translations as separate options.
- π¨π¦Canada joseph.olstad
ok I'll revert it as soon as the git repo comes back.
-
joseph.olstad β
committed 3e11661c on 3.0.x
Revert "Issue #3378586 by mlncn: Argument #3 ($currentTranslationOnly)...
-
joseph.olstad β
committed 3e11661c on 3.0.x
- π¨π¦Canada joseph.olstad
@mlncn, if you figure this issue out, please let us know.
Seems like it must be related to configuration options and translation settings? Otherwise others would likely have raised an issue sooner?
- π―π΄Jordan mohammad-fayoumi Amman
I encountered this issue on Drupal 10.3.6 with the
moderated_content_bulk_publish
module version 3.0.0-beta12.
The suggested patch didn't resolve the problem for me. However, after updating specific workflow settings, it started working. I believe the issue is related to how the workflow maps the publish and unpublish states. - π¨π¦Canada joseph.olstad
If there's some suggested changes for the README.md file, please let me know
- Merge request !32Issue #3378586 by mlncn, mohammad-fayoumi, joseph.olstad: Argument #3... β (Open) created by mohammad-fayoumi
- π―π΄Jordan mohammad-fayoumi Amman
I've added a steps to configure the corresponding workflow and updating the README.md file format