- π―π΄Jordan Rajab Natshah Jordan
- π―π΄Jordan ahmad abbad Jordan
Ahmad Abbad β made their first commit to this issueβs fork.
- π―π΄Jordan ahmad abbad Jordan
Since Varbase is using the lb_ux module
I added a patch to work with a core β¨ Add visibility control conditions to blocks within Layout Builder Needs work patch (10.0X).before applying this patch you should use the mentioned patch
- Status changed to Needs review
over 1 year ago 8:53am 7 May 2023 - Open on Drupal.org βCore: 9.5.5 + Environment: PHP 8.1 & MySQL 8last update
over 1 year ago Waiting for branch to pass - π―π΄Jordan abu-zakham
I have rewritten patch #2. I will improve the functionality in the future, but for now, I need to continue using the patch to update the module.
- π―π΄Jordan abu-zakham
Added access false to remove the html of the hidden section
- Merge request !59Issue #3322829 by n.ghunaim, abu-zakham, Ahmad Abbad, Mutasim Al-Shoura: Add Hide action to the section actions β (Merged) created by n.ghunaim
- π―π΄Jordan Rajab Natshah Jordan
Adding a β UX/UI designer responsibilities
- Status changed to Needs work
6 months ago 9:30am 29 May 2024 - π―π΄Jordan Rajab Natshah Jordan
Reviewed the MR for this issue.
And then had a look at the code for β¨ Add visibility control conditions to blocks within Layout Builder Needs workIn Drupal Core MR, they are doing this in the Block level
https://git.drupalcode.org/project/drupal/-/merge_requests/3627/diffs#18...In Varbase Layout Builder MR
The varbase_layout_builder.visibility_section route:
/layout_builder/visibility/section/{section_storage_type}/{section_storage}/{delta}
Has no{uuid}
for the sectionBut in the MR for Drupal Core
layout_builder.add_visibility
/layout_builder/visibility/block/{section_storage_type}/{section_storage}/{delta}/{uuid}/{plugin_id}
layout_builder.visibility
/layout_builder/visibility/block/{section_storage_type}/{section_storage}/{delta}/{uuid}
layout_builder.delete_visibility
/layout_builder/visibility/block/{section_storage_type}/{section_storage}/{delta}/{uuid}/{plugin_id}/delete
Better to add the
{uuid}
for the section in our case as the{delta}
may change at any time. but theuuid
for the section will be synced with section. - Status changed to Needs review
6 months ago 3:46pm 29 May 2024 - π―π΄Jordan Rajab Natshah Jordan
Had a one more round of testing.
I have a sound thought about the use{delta}
Tested with reorder of sections, and it's working well too.
No longer needing theuuid
, it is needed for blocks in the Drupal Core patch.
Moving forward with the merge -
Rajab Natshah β
committed c9f712b8 on 10.1.x authored by
n.ghunaim β
Issue #3322829 by n.ghunaim, abu-zakham, Ahmad Abbad, Mutasim Al-Shoura...
-
Rajab Natshah β
committed c9f712b8 on 10.1.x authored by
n.ghunaim β
- π―π΄Jordan Mutasim Al-Shoura
I enhanced this patch to also work with blocks, enabling us to hide sections and blocks.
- π―π΄Jordan Rajab Natshah Jordan
Thanks, Mutasim.
to better review what are you addtions on blocks.
1. Create a new branch from the current issue fork ( with latest merged work )
2. Commit the patch to it.
3. Create new Merge Requiest fro the branch - π―π΄Jordan abu-zakham
Thanks Mutasim and Rajab. I believe we should open a new issue specifically for hiding blocks feature as it has been committed and is close to completion.
- π―π΄Jordan Rajab Natshah Jordan
I agree with that.
In new issues.
Let us also check with our Product Owner and the Design team, to find a better look for
Section Action and Block Actions with hints/tooltips - π―π΄Jordan Mutasim Al-Shoura
Okay, I will create a new issue for the blocks and provide a patch for it.
- π―π΄Jordan Rajab Natshah Jordan
No further patches are needed for Varbase 10
Removed form the description - Status changed to Fixed
6 months ago 8:25am 6 June 2024 - π―π΄Jordan Rajab Natshah Jordan
β Released varbase_layout_builder-10.1.0 β
Automatically closed - issue fixed for 2 weeks with no activity.