- Issue created by @ambient.impact
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - @ambientimpact opened merge request.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Not currently mergeable. - @ambientimpact opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 4:56pm 2 May 2023 - 🇨🇦Canada ambient.impact Toronto
GitLab had a brain fart so ignore the first merge request (which didn't have anything in it); committed and pushed to a new merge request.
- Status changed to Fixed
over 1 year ago 6:33pm 3 May 2023 - Status changed to Needs work
over 1 year ago 8:50pm 4 May 2023 - 🇨🇦Canada ergonlogic Montréal, Québec 🇨🇦
I think this has made the non-dark-mode colours illegible
- Assigned to ambient.impact
- 🇨🇦Canada ambient.impact Toronto
Whoops. Yeah, that's very likely because you're using Claro which doesn't have a dark mode, but the browser and operating system are indicating they're in dark mode, so our CSS is kicking in. I can rework it so it kicks in just for the Gin theme when it's in dark mode, much as I hate to hard code a specific theme's implementation of this.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - @ambientimpact opened merge request.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 11:10pm 7 May 2023 - 🇨🇦Canada ambient.impact Toronto
Boom, fixed! Give it a shot and let me know if it works as intended now. I provided some detailed comments in the CSS to hopefully avoid this regression in the future.
- last update
over 1 year ago 13 pass - Status changed to Fixed
over 1 year ago 2:26am 12 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.