Contrib.social

Fix video transitions prematurely to the next slide before its completion when the slider have dots

Open on Drupal.org →
Created on 4 October 2023, about 1 year ago
Updated 15 October 2023, about 1 year ago

Problem/Motivation

Having a local video slide skipping at the end of the cycle of Slack Carousals in the hero slider

Steps to reproduce

Having an image as the first slide
And with number of local video slides
When the carousal is using an auto sliding config with a limited time
the last slide will keep skipping if it was a local video
Only when the dots indicator had a trigger with a click or swipe events

Proposed resolution

Fix the selector for the current slider if it was a local video slide
`.slide--${currentSlide}.slick-active`

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-9.0.16 → , varbase_heroslider_media-9.0.9 →

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

After the fix:
→

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

🐛 Bug report
Status

Fixed

Version

9.0

Component

Code

Created by

🇯🇴Jordan mohammad faqeh

Live updates comments and jobs are added and updated live.
  • Accessibility

    It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.

Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024