Account created on 27 August 2009, almost 15 years ago
#

Merge Requests

Recent comments

🇦🇺Australia steveworley

Hey frob! Yeah — that's right, submission to a HTTP endpoint, either a service that is remotely managed like VirusTotal or a HTTP endpoint that you manage to validate files.

For the initial release of this module, the HTTP request and response are hard coded so it might be 100% compatible with the VirusTotal spec. You can customise the name of the file upload and the key which the module will look in from the response but if it expects are more complicated request/response schema we'll need to accommodate a more pluggable solution to support that backend properly.

🇦🇺Australia steveworley

I've created a MR to resolve this; https://git.drupalcode.org/project/clamav/-/merge_requests/7. The CKEditor plugin doesn't pass through the tmp path in the file object but we can access the same values from the request object.

🇦🇺Australia steveworley

Just to add to this one, I haven't tested myself yet but it should be pushed into Quant as unpublished I will confirm that though as I would expect this to be expedited if that's not the case.

🇦🇺Australia steveworley

This issue looked to be caused by a race condition. The order of operations would mean that the database is not always available when Drupal calls TrafficRegistry::invalidateTag. This would result in the select query failing and resulting in being in a state where the table doesn't exist and Drupal not being able to recreate.

I've resolved the issue with:

https://github.com/quantcdn/drupal/pull/155/commits/4d87390da5fbc23c248a...

🇦🇺Australia steveworley

Tested, added a few minor changes to support this properly:

  • When constructing the http_response invalidation object we add a property for force so as to not conflict with tag exclusions
  • Moved getTypes() definition to the plugin
Production build 0.69.0 2024