D7: Use quant_get_base_url in remaining spots

Created on 21 January 2024, 10 months ago
Updated 3 March 2024, 9 months ago

Problem/Motivation

Followup to πŸ“Œ D7: Review usage of variable_get('quant_base_url', $base_url) Fixed . There are a couple of spots that still need changing and testing:

function _quant_queue_menu_paths(array $menus_filter = array()) {
  // @todo Use quant_get_base_url().
  global $base_url;
  $base = variable_get('quant_base_url', $base_url);

and

    // @fixme Should this be quant_get_base_url() instead of $base_url?
    if (!empty($domain) && stripos($base_url, $domain) == -1) {
      // @todo: Determine local vs. remote.
      continue;
    }

Steps to reproduce

Proposed resolution

  • Change and test these to see if functionality still works.
  • Review code for any additional spots

Remaining tasks

  1. Update code
  2. Review and test
  3. Commit :)

User interface changes

API changes

Data model changes

πŸ“Œ Task
Status

Needs review

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024