D7: Review usage of variable_get('quant_base_url', $base_url)

Created on 14 June 2023, over 1 year ago
Updated 21 January 2024, 10 months ago

Problem/Motivation

When looking at some code, I think I may have found a bug in the code where this is used:

$base = variable_get('quant_base_url', $base_url);

yet global $base_url; is not in the function. Needs a second look along with all usage of this code as it's in a bunch of places.

Steps to reproduce

Proposed resolution

Check the usage of this code throughout the modules to make sure it's correct.

$base = variable_get('quant_base_url', $base_url);

There is already a helper function:

quant_get_base_url

but it isn't widely used. Probably best to switch to using that to avoid missing the global $base_url; code.

Remaining tasks

  1. Review further
  2. Update code as required
  3. Review and test
  4. Commit :)

User interface changes

API changes

Data model changes

πŸ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States Kristen Pol Santa Cruz, CA, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024