Drupal 11 compatibility changes

CUSTOM PROJECTS -------------------------------------------------------------------------------- Quant Scanned on Fri, 09/22/2023 - 18:40. 11 warnings found. web/modules/custom/quantcdn/modules/quant_purger/src/StackMiddleware/UrlRegistra r.php: ┌──────────┬──────┬─────────────────────────────────────────────────────────────┐ │ STATUS │ LINE │ MESSAGE │ ├──────────┼──────┼─────────────────────────────────────────────────────────────┤ │ Check │ 60 │ Fetching deprecated class constant MASTER_REQUEST of class │ │ manually │ │ Drupal\quant_purger\StackMiddleware\UrlRegistrar: since │ │ │ │ symfony/http-kernel 5.3, use MAIN_REQUEST instead. To ease │ │ │ │ the migration, this constant won't be removed until Symfony │ │ │ │ 7.0. │ │ │ │ │ └──────────┴──────┴─────────────────────────────────────────────────────────────┘ web/modules/custom/quantcdn/quant.info.yml: ┌──────────┬──────┬────────────────────────────────────────────────────────────┐ │ STATUS │ LINE │ MESSAGE │ ├──────────┼──────┼────────────────────────────────────────────────────────────┤ │ Check │ 0 │ Value of core_version_requirement: ^9.3 || ^10 is not │ │ manually │ │ compatible with the next major version of Drupal core. See │ │ │ │ https://drupal.org/node/3070687. │ │ │ │ │ └──────────┴──────┴────────────────────────────────────────────────────────────┘ web/modules/custom/quantcdn/modules/quant_sitemap/quant_sitemap.info.yml: ┌──────────┬──────┬────────────────────────────────────────────────────────────┐ │ STATUS │ LINE │ MESSAGE │ ├──────────┼──────┼────────────────────────────────────────────────────────────┤ │ Check │ 0 │ Value of core_version_requirement: ^9.3 || ^10 is not │ │ manually │ │ compatible with the next major version of Drupal core. See │ │ │ │ https://drupal.org/node/3070687. │ │ │ │ │ └──────────┴──────┴────────────────────────────────────────────────────────────┘ web/modules/custom/quantcdn/modules/quant_search/quant_search.info.yml: ┌──────────┬──────┬────────────────────────────────────────────────────────────┐ │ STATUS │ LINE │ MESSAGE │ ├──────────┼──────┼────────────────────────────────────────────────────────────┤ │ Check │ 0 │ Value of core_version_requirement: ^9.3 || ^10 is not │ │ manually │ │ compatible with the next major version of Drupal core. See │ │ │ │ https://drupal.org/node/3070687. │ │ │ │ │ └──────────┴──────┴────────────────────────────────────────────────────────────┘ web/modules/custom/quantcdn/modules/quant_cron/quant_cron.info.yml: ┌──────────┬──────┬────────────────────────────────────────────────────────────┐ │ STATUS │ LINE │ MESSAGE │ ├──────────┼──────┼────────────────────────────────────────────────────────────┤ │ Check │ 0 │ Value of core_version_requirement: ^9.3 || ^10 is not │ │ manually │ │ compatible with the next major version of Drupal core. See │ │ │ │ https://drupal.org/node/3070687. │ │ │ │ │ └──────────┴──────┴────────────────────────────────────────────────────────────┘ web/modules/custom/quantcdn/modules/quant_tome/quant_tome.info.yml: ┌──────────┬──────┬────────────────────────────────────────────────────────────┐ │ STATUS │ LINE │ MESSAGE │ ├──────────┼──────┼────────────────────────────────────────────────────────────┤ │ Check │ 0 │ Value of core_version_requirement: ^9.3 || ^10 is not │ │ manually │ │ compatible with the next major version of Drupal core. See │ │ │ │ https://drupal.org/node/3070687. │ │ │ │ │ └──────────┴──────┴────────────────────────────────────────────────────────────┘ web/modules/custom/quantcdn/modules/quant_purger/quant_purger.info.yml: ┌──────────┬──────┬────────────────────────────────────────────────────────────┐ │ STATUS │ LINE │ MESSAGE │ ├──────────┼──────┼────────────────────────────────────────────────────────────┤ │ Check │ 0 │ Value of core_version_requirement: ^9.3 || ^10 is not │ │ manually │ │ compatible with the next major version of Drupal core. See │ │ │ │ https://drupal.org/node/3070687. │ │ │ │ │ └──────────┴──────┴────────────────────────────────────────────────────────────┘ web/modules/custom/quantcdn/modules/quant_webform/quant_webform.info.yml: ┌──────────┬──────┬────────────────────────────────────────────────────────────┐ │ STATUS │ LINE │ MESSAGE │ ├──────────┼──────┼────────────────────────────────────────────────────────────┤ │ Check │ 0 │ Value of core_version_requirement: ^9.3 || ^10 is not │ │ manually │ │ compatible with the next major version of Drupal core. See │ │ │ │ https://drupal.org/node/3070687. │ │ │ │ │ └──────────┴──────┴────────────────────────────────────────────────────────────┘ web/modules/custom/quantcdn/modules/quant_api/quant_api.info.yml: ┌──────────┬──────┬────────────────────────────────────────────────────────────┐ │ STATUS │ LINE │ MESSAGE │ ├──────────┼──────┼────────────────────────────────────────────────────────────┤ │ Check │ 0 │ Value of core_version_requirement: ^9.3 || ^10 is not │ │ manually │ │ compatible with the next major version of Drupal core. See │ │ │ │ https://drupal.org/node/3070687. │ │ │ │ │ └──────────┴──────┴────────────────────────────────────────────────────────────┘

Comments & Activities

Issue created by @Kristen Pol
Comment 9 months ago →
🇮🇳India sarwan
Hi @Kristen Pol,
I have fixed this Drupal 11 compatibility issues and also attached patch ,
please review and verify.
Status changed to Needs review 9 months ago11:03am 22 September 2023
Comment 9 months ago →
🇮🇳India sarwan
Assigned to Kristen Pol
Comment 9 months ago →
🇺🇸United States Kristen Pol Santa Cruz, CA, USA
I'm taking a look.
Status changed to Postponed 9 months ago11:24pm 28 September 2023
Comment 9 months ago →
🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Work is happening here:

https://github.com/quantcdn/drupal/compare/8.x-1.x...feature/d11-compati...

Note that I had to add an empty validateForm method to handle a fatal error when saving the quant_api settings form.

I tested it with Drupal 10.1 and 11 dev and the Umami profile and it worked as expected.

Postponing until this gets merged (which I merged with these changes as it's required for Quant to work with aggregation):

🐛 Handle Drupal 10.1 aggregation issues Fixed
Status changed to Needs review 9 months ago7:26am 29 September 2023
Comment 9 months ago →
🇺🇸United States Kristen Pol Santa Cruz, CA, USA
D10 fixes have been merged so reopening this.
Issue was unassigned.
Status changed to Postponed 9 months ago10:53pm 29 September 2023
Comment 9 months ago →
🇦🇺Australia steveworley
Kristen Pol → credited steveworley → .
Comment 9 months ago →
🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Ran into an issue with a webp image so moving this back to postponed for now.

https://github.com/quantcdn/drupal/pull/191
Assigned to Kristen Pol
Status changed to Needs review 6 months ago5:38am 4 January 2024
Comment 6 months ago →
🇦🇺Australia stooit
Kristen Pol → credited stooit → .
Comment 6 months ago →
🇺🇸United States Kristen Pol Santa Cruz, CA, USA
This has been moved forward.
Issue was unassigned.
Status changed to Postponed 5 months ago12:51am 21 January 2024
Comment 5 months ago →
🇺🇸United States Kristen Pol Santa Cruz, CA, USA
We shouldn't merge this yet because some of our dependencies are D11 compatible yet. Moving this to postponed for now.

https://www.drupal.org/project/purge → - not compatible as of 19 Jan 2024
https://www.drupal.org/project/simple_sitemap → - not compatible as of 19 Jan 2024
https://www.drupal.org/project/token → - not compatible as of 19 Jan 2024
https://www.drupal.org/project/tome → - not compatible as of 19 Jan 2024
https://www.drupal.org/project/webform → - not compatible as of 19 Jan 2024

Drupal 11 compatibility changes

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities