Quant simple sitemap UX issues.

Open on Drupal.org →

Created on 21 September 2023, about 1 year ago

Updated 1 March 2024, 9 months ago

Problem/Motivation

When testing 🐛 Quant sitemap needs sitemap.xsl to show in browser Fixed and 🐛 Quant sitemap option shows up when simple_sitemap isn't installed Fixed , I noticed that there were a couple issues with the /index/sitemap.xml sitemap.

Steps to reproduce

Install quant, quant_api and quant_sitemap modules
Update Quant API settings and sync content
Go to: /admin/config/quant/seed

You'll see an error message:

quant_sitemap requires simple_sitemap or xmlsitemap

Install simple_sitemap module
Go to: /admin/config/quant/seed
Select Sitemaps and Trigger the batchcheckboxes
Click Save and Queue button
Note the errors: Non-200 response for /sitemap.xml: 404 and Non-200 response for /index/sitemap.xml: 404
This is because even though the module is enabled the sitemaps are not
Go to: /admin/config/search/simplesitemap
Note Default is "pending" and Sitemap index is "disabled"
Click Rebuild queue & generate button
Now there will be a default sitemap so that should no longer show a 404 when seeding
Click Edit link for Sitemap Index
Select Enabled checkbox and Save button
Click Rebuild queue & generate button
Both sitemaps will be published now
Seed again like above and there should be no 404 errors
Check the pages exists on the Drupal site: /sitemap.xml and /index/sitemap.xml
Check the pages exists on the Quant static site: /sitemap.xml and /index/sitemap.xml
Note that the /sitemap.xml page looks fine on both
Note that the /index/sitemap.xml looks okay in Drupal but not on the Quant site (/sitemap_generator/default/sitemap.xsl was synced but not /sitemap_generator/index/sitemap.xsl

Proposed resolution

For the 404 issue, it would be good if only the published sitemaps were handled by Quant (though it could log a warning if there are disabled or pending sitemaps)
For the visual issue, it looks like a xsl file will need to be synced for each sitemap

Remaining tasks

Determine resolution
Update code
Review and test
Commit :)

User interface changes

The user won't see 404 errors on the page when syncing sitemaps (though they may exist in the logs). And all sitemaps will render so they can be read in the browser.

API changes

Data model changes

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States Kristen Pol Santa Cruz, CA, USA

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Comments & Activities

Issue created by @Kristen Pol
Comment 10 months ago →
🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Making this a meta issue.
Comment 10 months ago →
🇺🇸United States Kristen Pol Santa Cruz, CA, USA
After debugging, it looks like getSimpleSitemaps will need a rewrite using $this->getSitemapManager()->getSitemaps() to get all the sitemaps and then check each one for:

$enabled = $sitemap->isEnabled(); $contentStatus = $sitemap->contentStatus();
and to not include the sitemap if either of these is false. And, will need to get the appropriate xsl file for each sitemap that is included.
Assigned to Kristen Pol
Status changed to Needs review 10 months ago6:22am 31 January 2024
Comment 10 months ago →
🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Fixes are here: https://github.com/quantcdn/drupal/pull/226
Issue was unassigned.
Status changed to Fixed 9 months ago2:43am 28 February 2024
Comment 9 months ago →
🇦🇺Australia steveworley
Kristen Pol → credited steveworley → .
Comment 9 months ago →
🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Merged in GitHub. Will be synced to d.o repo and part of next release.
Status changed to Fixed 9 months ago9:30pm 1 March 2024
Comment 9 months ago →
🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Part of 1.6.1 release → .

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024