Can not be disabled via the config form

Created on 26 February 2024, 4 months ago

Updated 3 April 2024, 3 months ago

There is a setting to allow disable the anti-virus scan in the config form (/admin/config/httpav).
But this setting is not working.

The bug is introduced by line 42 in /src/Form/ConfigForm.php

'#default_value' => $config->get('enabled') ?: TRUE,

The line above means that if the config value is false or 0, then set it to TRUE. Therefore, this value can never be false.

If that line is changed to

'#default_value' => $config->get('enabled') ?? TRUE,

Then the scan can be disabled by this config form.

Review the proposed fix.

N/A

N/A

N/A

🐛 Bug report

Status

Fixed

Version

1.1

Component

Code

Created by

🇦🇺Australia Mingsong 🇦🇺

Live updates comments and jobs are added and updated live.

Merge Requests

Issue created by @Mingsong
Comment 4 months ago →
🇮🇳India Prem Suthar gujrat
Prem Suthar → made their first commit to this issue’s fork.
Merge request !1httpav-3423716/3423716-can-not-be-disabled: Done the changes and review the changes are working . → (Merged) created by Prem Suthar
Status changed to Needs review 4 months ago6:35am 26 February 2024
Comment 4 months ago →
🇮🇳India Prem Suthar gujrat
Created The mr as per issue suggestion and its working fine as per database config.
Status changed to Fixed 4 months ago12:13am 6 March 2024
Comment 4 months ago →
🇦🇺Australia steveworley
Comment 3 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.
Comment 3 months ago →
🇮🇳India Prem Suthar gujrat

Production build 0.69.0 2024