- Issue created by @Project Update Bot
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #11-121090This patch was created using these packages:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.7
- palantirnet/drupal-rector: 0.20.1
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-177898These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.1
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.1
- First commit to issue fork.
- Status changed to Needs work
19 days ago 5:41am 28 May 2024 - 🇮🇳India deepakkm
Hello @dave-reid - I have a suggestion on the new release for embed module and was thinking if there is any plan to drop Drupal 9 support as it has ckeditor4 dependency which will not be supported in Drupal 11. Would it be ok if i create an MR with dropped support for Drupal 9?
- Status changed to Needs review
17 days ago 2:11pm 30 May 2024 This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-185727These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.1
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.1
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-188138These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.2
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.2
This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-188815These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.2
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.2
- Status changed to Needs work
11 days ago 6:29am 5 June 2024 - 🇮🇳India chandu7929 Pune
@deepakkm - I verified MR 16 and can see following deprecations, hence needs work.
================================================================================ Embed, -- Scanned on Wed, 06/05/2024 - 06:23 FILE: modules/contrib/embed/src/Form/EmbedButtonForm.php STATUS LINE MESSAGE -------------------------------------------------------------------------------- Check manually 117 Call to deprecated function watchdog_exception(). Deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. Use Use Drupal\Core\Utility\Error::logException() instead. -------------------------------------------------------------------------------- FILE: modules/contrib/embed/tests/src/Unit/DomHelperTraitTest.php STATUS LINE MESSAGE -------------------------------------------------------------------------------- Check manually 35 Missing call to parent::setUp() method. --------------------------------------------------------------------------------
- Assigned to prabha1997
- 🇮🇳India deepakkm
Remaining phpcs and phpstan issue should be fixed as part of separate ticket. I think MR 16 is enough for drupal 11 comptability
- Status changed to Needs review
11 days ago 8:16am 5 June 2024 - Status changed to Needs work
11 days ago 9:13am 5 June 2024 - Status changed to Needs review
11 days ago 9:52am 5 June 2024 - Status changed to Needs work
10 days ago 6:51am 6 June 2024 - 🇮🇳India vishalkhode
Requested some changes in MR. Please see. Hence, moving it back.
- Issue was unassigned.
- Status changed to Needs review
10 days ago 11:43am 6 June 2024 - Status changed to RTBC
6 days ago 10:48am 10 June 2024 - 🇮🇳India Rajeshreeputra Pune
Verified changes with Drupal 11 rc version and working fine.
- Status changed to Needs work
6 days ago 12:30pm 10 June 2024 - 🇮🇳India ankitv18
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
- Status changed to Needs review
5 days ago 8:41am 11 June 2024 - Status changed to RTBC
5 days ago 8:51am 11 June 2024 - 🇮🇳India ankitv18
Changes done in the MR!16 looks fine by me, hence marking this RTBC.
Also I'm linking the other issues.