Contrib.social

Automated Drupal 11 compatibility fixes for embed

Open on Drupal.org →
Created on 17 March 2024, 3 months ago
Updated 18 June 2024, 8 days ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs review

Version

1.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Project Update Bot
  • Comment 3 months ago →
    Project Update Bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #11-121090

    This patch was created using these packages:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.7
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !15Automated Project Update Bot fixes → (Open) created by Project Update Bot
  • Pipeline finished with Failed
    3 months ago
    #121445
  • Pipeline finished with Failed
    3 months ago
    #121446
  • Comment about 1 month ago →
    Project Update Bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

    Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

    Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

    The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-177898

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.1
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.1
  • Pipeline finished with Failed
    about 1 month ago
    Total: 207s
    #178313
  • First commit to issue fork.
  • Merge request !16Drupal 11 Compatibility. → (Open) created by deepakkm
  • Pipeline finished with Failed
    about 1 month ago
    Total: 239s
    #180247
  • Status changed to Needs work 29 days ago
  • Comment 29 days ago →
    🇮🇳India deepakkm
  • Comment 29 days ago →
    🇮🇳India deepakkm

    Hello @dave-reid - I have a suggestion on the new release for embed module and was thinking if there is any plan to drop Drupal 9 support as it has ckeditor4 dependency which will not be supported in Drupal 11. Would it be ok if i create an MR with dropped support for Drupal 9?

  • Pipeline finished with Failed
    28 days ago
    Total: 172s
    #184998
  • Pipeline finished with Success
    27 days ago
    Total: 272s
    #185686
  • Status changed to Needs review 27 days ago
  • Comment 27 days ago →
    Project Update Bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-185727

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.1
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.1
  • Pipeline finished with Failed
    27 days ago
    Total: 273s
    #186142
  • Comment 24 days ago →
    Project Update Bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-188138

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.2
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.2
  • Pipeline finished with Failed
    24 days ago
    Total: 200s
    #188772
  • Comment 24 days ago →
    Project Update Bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-188815

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.2
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.2
  • Pipeline finished with Failed
    24 days ago
    Total: 207s
    #188934
  • Status changed to Needs work 21 days ago
  • Comment 21 days ago →
    🇮🇳India chandu7929 Pune

    @deepakkm - I verified MR 16 and can see following deprecations, hence needs work.

    ================================================================================
Embed, --
Scanned on Wed, 06/05/2024 - 06:23

FILE: modules/contrib/embed/src/Form/EmbedButtonForm.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 117  Call to deprecated function watchdog_exception(). Deprecated
                    in drupal:10.1.0 and is removed from drupal:11.0.0. Use Use 
                    Drupal\Core\Utility\Error::logException() instead.          
--------------------------------------------------------------------------------

FILE: modules/contrib/embed/tests/src/Unit/DomHelperTraitTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 35   Missing call to parent::setUp() method.                     
--------------------------------------------------------------------------------
  • Assigned to prabha1997
  • Comment 21 days ago →
    🇮🇳India prabha1997

    I am working on this issue

  • Pipeline finished with Failed
    21 days ago
    Total: 171s
    #191527
  • Pipeline finished with Success
    21 days ago
    Total: 169s
    #191538
  • Comment 21 days ago →
    🇮🇳India deepakkm

    Remaining phpcs and phpstan issue should be fixed as part of separate ticket. I think MR 16 is enough for drupal 11 comptability

  • Status changed to Needs review 21 days ago
  • Comment 21 days ago →
    🇮🇳India deepakkm
  • Status changed to Needs work 21 days ago
  • Comment 21 days ago →
    🇮🇳India chandu7929 Pune
  • Pipeline finished with Canceled
    21 days ago
    Total: 24s
    #191648
  • Pipeline finished with Success
    21 days ago
    Total: 176s
    #191650
  • Status changed to Needs review 21 days ago
  • Comment 21 days ago →
    🇮🇳India deepakkm
  • Status changed to Needs work 20 days ago
  • Comment 20 days ago →
    🇮🇳India vishalkhode

    Requested some changes in MR. Please see. Hence, moving it back.

  • Pipeline finished with Failed
    20 days ago
    Total: 235s
    #192444
  • Pipeline finished with Success
    20 days ago
    Total: 222s
    #192458
  • Comment 20 days ago →
    🇮🇳India prabha1997
  • Issue was unassigned.
  • Comment 20 days ago →
    🇮🇳India prabha1997
  • Pipeline finished with Failed
    20 days ago
    Total: 194s
    #192568
  • Pipeline finished with Success
    20 days ago
    Total: 206s
    #192572
  • Pipeline finished with Success
    20 days ago
    Total: 331s
    #192626
  • Pipeline finished with Canceled
    20 days ago
    Total: 130s
    #192635
  • Pipeline finished with Failed
    20 days ago
    Total: 570s
    #192639
  • Pipeline finished with Success
    20 days ago
    Total: 172s
    #192655
  • Status changed to Needs review 20 days ago
  • Comment 20 days ago →
    🇮🇳India deepakkm
  • Status changed to RTBC 16 days ago
  • Comment 16 days ago →
    🇮🇳India Rajeshreeputra Pune

    Verified changes with Drupal 11 rc version and working fine.

  • Status changed to Needs work 16 days ago
  • Comment 16 days ago →
    🇮🇳India ankitv18
  • Pipeline finished with Success
    16 days ago
    Total: 172s
    #195554
  • Pipeline finished with Success
    15 days ago
    Total: 266s
    #196107
  • Comment 15 days ago →
    🇮🇳India ankitv18

    ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.

  • Status changed to Needs review 15 days ago
  • Comment 15 days ago →
    🇮🇳India deepakkm
  • Status changed to RTBC 15 days ago
  • Comment 15 days ago →
    🇮🇳India ankitv18

    Changes done in the MR!16 looks fine by me, hence marking this RTBC.
    Also I'm linking the other issues.

  • Status changed to Needs review 8 days ago
  • Comment 8 days ago →
    Project Update Bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-199781

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.2
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.3
  • Pipeline finished with Failed
    8 days ago
    Total: 177s
    #201406
contrib.social Blog FAQ Discussions
Production build 0.69.0 2024