🇺🇸United States @jayemel

To add insult to injury, if you try to create your own "default" view mode, you get "The machine-readable name is already in use. It must be unique."

There should absolutely be either a "default" option, or unchecked "Allowed Entity Embed Display plugins" should be ignored completely while embedding.

"If none are selected, all are allowed." makes no sense, and that's obvious to everyone because of the disclaimer that follows "Note that these are the plugins which are allowed for this entity type, all of these might not be available for the selected entity."

The leaves entities without a custom display mode in the awkward situation where they HAVE to create a display mode for the embed button to make sense. I.e. it's extra work and config.

jayemel → created an issue.

Updating to embed 1.8 has broken our ability to use entity_embed in ckeditor5. We get a spinner, then nothing. This essentially breaks any site building for us.

In the logs we get:

ArgumentCountError: Too few arguments to function Drupal\embed\EmbedType\EmbedTypeBase::__construct(), 3 passed in /code/web/modules/contrib/entity_embed/src/Plugin/EmbedType/Entity.php on line 56 and exactly 4 expected in Drupal\embed\EmbedType\EmbedTypeBase->__construct() (line 29 of /code/web/modules/contrib/embed/src/EmbedType/EmbedTypeBase.php).

What is the solution? Where is the embed module even coming from, it's not in our composer.json. Is it in core? We need to lock it down to 1.7 because 1.8 has broken our sites.

symfony/framework-bundle (along with symfony/cache) v6.4.10 was just released. Anyone know if this fixes the cachewarmer regression talked about above?

I was able to get around this by going to /admin/structure/webform/config/elements and settings the "HTML editor settings" "text formats" from -default- to a format that uses ckeditor5.

In the meantime, I fixed this with CSS added to my ckeditor stylesheet.

/* Change display from "grid" to "block" to place the metadata panel back under the node edit form */
.node-form .layout-form {
  display: block;
}

/* Set the node edit form to 100% width like it was previously */
.node-form .layout-form .layout-region--main {
  width: 100%;
}

Same issue here. Meta position "no longer works" with 10.3.0 and the default Drupal admin theme, Claro. The metadata panels appears in the default position on the right after installing 10.3.0. It was working on 10.2.7.

Same issue...I can't uninstall ckeditor because its webform dependency. See config. Is there a place in webform to set the "editor" to ckeditor5?

editor.editor.webform_default

langcode: en
status: true
dependencies:
  config:
    - filter.format.webform_default
  module:
    - ckeditor
    - webform
format: webform_default
editor: ckeditor
settings:
  toolbar:
    rows:
      -
        -
          name: Formatting
          items:
            - Format
            - Bold
            - Italic
            - Superscript
            - Subscript
        -
          name: Media
          items:
            - SpecialChar
            - ImceImage
        -
          name: Linking
          items:
            - DrupalLink
            - DrupalUnlink
        -
          name: Lists
          items:
            - NumberedList
            - BulletedList
        -
          name: Indentation
          items:
            - Outdent
            - Indent
        -
          name: 'Block Formatting'
          items:
            - Blockquote
        -
          name: Tools
          items:
            - Source
            - Maximize
  plugins: {  }

jayemel → created an issue.

I ran into this as well while creating an input format to only allow Entity embeds. CKEditor toolbar and entity embeds fail to render without the link button added to the toolbar. I get the same error in the issue description.

Maybe has something to do with the balloon that comes up when clicking an embedded entity? "Link Entity Embed (cmd-k)" needs the link plugin?

Is there a way to disable this behavior? I don't have the need to link entities.

This is very confusing for content creators. It would be really helpful to have a configurable cache.

Looks like this is a duplicate of this Preview responses shouldn't be cached by default. 🐛 Preview responses shouldn't be cached by default. Active .

jayemel → created an issue.

jayemel → created an issue.

So for anyone else stumbling upon this, yes, you have to create a specific stylesheet for ckeditor5 , where all elements are prefixed with "ck-content", per this page:  https://www.drupal.org/node/3259165 →

I preferred the ease of just pointing it to your theme stylesheet and done. 

Sooo adding "ckeditor5-stylesheets" to the theme.info.yml overrides the admin theme styles, but doesn't actually style content in the wysiwyg? I don't understand this. I want the stylesheet to style what's in the actual wysiwyg, not the admin theme. I guess that's why CKEditor 4 put the textareas inside iframes?

Is this fixed? I am seeing this on cron runs after uninstalling paragraphs.

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "paragraph" entity type does not exist. in Drupal\Core\Entity\EntityTypeManager->getDefinition() (line 139 of /code/web/core/lib/Drupal/Core/Entity/EntityTypeManager.php).

Reinstalling, running cron, uninstalling is not an option on 30+ sites, nor is editing the database. Any other suggestions?

The module was uninstalled the correct way, removed any entities, config, etc., then uninstalled. Module uninstalled fine, but this persistent error throw during cron runs.

A custom theme. It's not doing anything special...just  a normal image field attached to an entity, displayed as "URL to image", with a custom media view mode that is set to display "URL to image". 

I think the greater point is that something has changed that makes "visually hidden" labels suddenly appear when using "URL to image". One could argue that it should be set to hidden.. and we probably just set it "visually hidden" before and left it like that because it worked. 

But one could also argue that using "URL to image" should always ignore the label settings, because it's not the "URL to image" anymore if it has label data packed in there. That's how it used to work, so something changed, whether this is a regression or not is up for debate I guess.

We are seeing this too. After upgrading from 9.5.11 to 10.2.5, first thing we noticed was many images using "URL to image" display mode with "visually hidden" label, had broken URLs. Inspecting the URLs, we saw that the field label (and entity name!?) was being added to the URL, where previously it wasn't.

so previoulsy the url would have correctly output /sites/default/files/filename.jpg now it was output as /our_custom_entity_name/Image/sites/default/files/filename.jpg

We needed to switch the label to "hidden" to get it to actually hide and output the correct "URL to image".

So it seems visually hidden is behaving differently than before, at least when used in a media display mode with "url to image" format.

By not first changing all formats to ckeditor5 before upgrading to 10, this will essentially lock users out selecting a format after upgrading. Trying to change them after the fact, you can't even get to the page, without reaching the Drupal\Component\Plugin\Exception\PluginNotFoundException: The "ckeditor" plugin does not exist.

This just smacks of an annoying archetypal drupalism that can frustrate unexperienced devs... if the plugin doesn't exist, it shouldn't just crash the site. It should handle it elegantly in such a way that at least allows the user to select a plugin that DOES exist. No disrespect to anyone's hard work, I know this isn't easy stuff.

drush theme:un classy

The way to solve this is to add the modules back, install them to get rid of the error, then uninstall them correctly: 1. drush pmu 2. drush cex to update the core.extension.yml.

@sassafrass comment is the correct way to do this, and preferred over editing a live database which can end badly. Just re-add the module, enable it on live, then hit the update.php page on live, then disable the module. Finally remove it from composer.json if desired. Even if there is no update waiting on update.php, just hitting the page with the module installed is enough to clear this warning.
I ran into this with migrate, migrate_tools.

I ran into this. Clicking the time field input adds a space before am/pm. if the "accepted format" on the field doesn't have a space, then it will fail.

A workaround:
The accepted format is configurable on the date field under "Date entry options". The default formats in that dropdown do not have a space before am/pm. But you can add your own format options to that dropdown under: /admin/config/regional/date-time/formats. E.g. Add a new format with a space before am/pm "M d, Y - g:i a". Then set this as your "accepted format" on the field.