- Issue created by @tgauges
- π©πͺGermany tgauges
I found out that adding
core/ckeditor5.link
to theentity_embed/entity_embed
library andlink.LinkEditing
andlink.LinkUI
to plugins entry of the CKEditor 5 plugin PHP class fixes the initial problem.
This causes another error very unhelpful error:
TypeError: e is undefined
- π©πͺGermany tgauges
The error seems to be caused by linkediting.js#L394 because the
'link'
command ist not available as well. The same issue will pop up a few lines above. - Merge request !30Draft: [#3399844] [DO NOT MERGE, use against 8.x-1.5] Make CKEditor 5 plugin work when the "Link" plugin is not enabled β (Open) created by tgauges
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 3:26pm 7 November 2023 - π©πͺGermany tgauges
My changes in the issue fork work for my use case. I'm not sure that I found every use of the link dependency, please review.
- πΊπΈUnited States jayemel
I ran into this as well while creating an input format to only allow Entity embeds. CKEditor toolbar and entity embeds fail to render without the link button added to the toolbar. I get the same error in the issue description.
Maybe has something to do with the balloon that comes up when clicking an embedded entity? "Link Entity Embed (cmd-k)" needs the link plugin?
Is there a way to disable this behavior? I don't have the need to link entities.
- Status changed to Needs work
5 months ago 8:55pm 11 July 2024 - ππΊHungary Balu Ertl Budapest πͺπΊ
I can confirm the issue is reproducible with the latest HEAD of this module on 10.1.x and 10.2.x core versions both. (On 10.3.x no βEβ button appears on the filter format settings page.)
The suggested solution resolves the problem indeed: the WYSIWYG editor's toolbar loads & works as expected even if the only single button is the one with the letter βEβ on it. (No link button is needed to be present.)
The merge request currently conflicts with the target branch 8.x-1.x in the /js/build/drupalentity.js file. As JavaScript falls out of my expertise domain, thus I'll let someone with more confidence in JS resolve the conflict. Hence moving to Needs work.
- Merge request !42[#3399844] Make CKEditor 5 plugin work when the "Link" plugin is not enabled β (Open) created by tgauges
- Status changed to Needs review
5 months ago 1:55pm 17 July 2024 - π©πͺGermany tgauges
I created a new branch and MR against 8.x-1.6: https://git.drupalcode.org/project/entity_embed/-/merge_requests/42
- πΊπΈUnited States possibri
Tested #10 and that looks to have fixed the error. Having people test it now, but upon initial checks things seem to work as expected. Thanks @tgauges!