@cilefen Bisected. First time using that; it's really nice!
2172d1009cec0e8f908a51fb2c99a1eb06b8b6da is the first bad commit commit 2172d1009cec0e8f908a51fb2c99a1eb06b8b6da Author: Alex Pott <alex.a.pott@googlemail.com> Date: Thu Feb 22 08:52:28 2024 +0000 Issue #3379885 by catch, Wim Leers: Use MessagesCommand in BigPipe to remove special casing of the messages placeholder (cherry picked from commit 44c345dd9b8e2e1fb7131868a5d8b27c57e5b8e3) core/modules/big_pipe/big_pipe.services.yml | 2 +- core/modules/big_pipe/src/Render/BigPipe.php | 79 +++++----------------- .../big_pipe/tests/src/Functional/BigPipeTest.php | 8 +-- .../FunctionalJavascript/BigPipeRegressionTest.php | 9 ++- .../tests/src/Unit/Render/FiberPlaceholderTest.php | 4 +- .../tests/src/Unit/Render/ManyPlaceholderTest.php | 4 +- 6 files changed, 32 insertions(+), 74 deletions(-)
RE: https://www.drupal.org/project/drupal/issues/3456176#comment-15654990 🐛 10.3 upgrade now missing status-message theme suggestions Active
@alexpott Could you please include more complete steps? I am not able to enable the system_test module...
Unable to install modules system_test due to missing modules system_test.
- 🇺🇸United States cilefen
@solideogloria Could you perform a git bisect on a Git checkout of Drupal Core to definitively identify the commit that changed behavior?
If I set a breakpoint in 10.2,
StatusMessages::renderMessages()
is called. So the render placeholder element's callback is not being properly called in 10.3 somehow?I set a breakpoint in
\Drupal\Core\Render\Renderer.php
. When theSystemMessagesBlock
is being rendered,StatusMessages::renderMessages()
is never called. Here is the block's$elements
array:Array ( [#theme] => block [#attributes] => Array() [#contextual_links] => Array ( [block] => Array ( [route_parameters] => Array ( [block] => my_custom_theme_messages ) ) ) [#weight] => -4 [#configuration] => Array ( [id] => system_messages_block [label] => Status messages [label_display] => 0 [provider] => system ) [#plugin_id] => system_messages_block [#base_plugin_id] => system_messages_block [#derivative_plugin_id] => [#id] => my_custom_theme_messages [#pre_render] => Array ( [0] => Drupal\block\BlockViewBuilder::preRender ) [#cache] => Array ( [contexts] => Array ( [0] => languages:language_interface [1] => theme [2] => user.permissions ) [tags] => Array ( [0] => block_view [1] => config:block.block.my_custom_theme_messages ) [max-age] => -1 [keys] => Array ( [0] => entity_view [1] => block [2] => my_custom_theme_messages ) ) [#attached] => Array() [#lazy_builder_built] => 1 [content] => Array ( [#type] => status_messages [#include_fallback] => 1 ) [#children] => )
- 🇬🇧United Kingdom Ok4p1 Glasgow
Hello, the patch mitigates the issue but I am still experiencing it
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
If I start from 10.3.x and do:
composer require drush/drush vendor/bin/drush si -y -v standard vendor/bin/drush en system_test -y vendor/bin/drush ev "\Drupal::state()->set('system_test.front_page_output', 1);"
Here's the HTML I get for the status message that appears.
<div class="region region--highlighted grid-full layout--pass--content-medium"> <!-- START RENDERER --> <!-- CACHE-HIT: No --> <!-- CACHE TAGS: * block_view * config:block.block.olivero_messages --> <!-- CACHE CONTEXTS: * languages:language_interface * theme * user.permissions --> <!-- CACHE KEYS: * entity_view * block * olivero_messages --> <!-- CACHE MAX-AGE: -1 --> <!-- PRE-BUBBLING CACHE TAGS: * block_view * config:block.block.olivero_messages --> <!-- PRE-BUBBLING CACHE CONTEXTS: * languages:language_interface * theme * user.permissions --> <!-- PRE-BUBBLING CACHE KEYS: * entity_view * block * olivero_messages --> <!-- PRE-BUBBLING CACHE MAX-AGE: -1 --> <!-- RENDERING TIME: 0.000603199 --> <!-- THEME DEBUG --> <!-- THEME HOOK: 'block' --> <!-- FILE NAME SUGGESTIONS: ▪️ block--highlighted--id--olivero-messages.html.twig ▪️ block--highlighted--plugin-id--system-messages-block.html.twig ▪️ block--highlighted.html.twig ▪️ block--olivero-messages.html.twig ✅ block--system-messages-block.html.twig ▪️ block--system.html.twig ▪️ block.html.twig --> <!-- BEGIN OUTPUT from 'core/modules/system/templates/block--system-messages-block.html.twig' --> <div data-drupal-messages-fallback="" class="hidden messages-list"></div> <!-- THEME DEBUG --> <!-- THEME HOOK: 'status_messages' --> <!-- 💡 BEGIN CUSTOM TEMPLATE OUTPUT from 'core/themes/olivero/templates/misc/status-messages.html.twig' --> <div data-drupal-messages="" class="messages-list"> <div class="messages__wrapper layout-container"> <div class="messages-list__item messages messages--status" data-drupal-selector="messages" role="contentinfo" aria-label="Status message" data-once="messages"> <div class="messages__container" data-drupal-selector="messages-container"> <div class="messages__header"> <h2 class="visually-hidden">Status message</h2> <div class="messages__icon"> <svg xmlns="http://www.w3.org/2000/svg" width="32px" height="32px" viewBox="0 0 32 32"> <path d="M26.8,12.6c0,0.4-0.1,0.7-0.4,0.9L15.1,24.9c-0.2,0.2-0.6,0.4-1,0.4c-0.3,0-0.7-0.1-0.9-0.4l-7.5-7.5c-0.2-0.2-0.4-0.6-0.4-0.9c0-0.4,0.1-0.7,0.4-1l1.9-1.9c0.2-0.2,0.6-0.4,0.9-0.4c0.4,0,0.7,0.1,0.9,0.4l4.7,4.7l8.5-8.5c0.2-0.2,0.6-0.4,0.9-0.4c0.4,0,0.7,0.1,0.9,0.4l1.9,1.9C26.6,11.9,26.8,12.3,26.8,12.6z M32,16c0-8.8-7.2-16-16-16C7.2,0,0,7.2,0,16c0,8.8,7.2,16,16,16C24.8,32,32,24.8,32,16z"></path> </svg> </div> </div> <div class="messages__content"> On front page. </div> <div class="messages__button"><button type="button" class="messages__close"><span class="visually-hidden">Close message</span></button></div></div> </div> </div> </div> TEST TEST TEST! <!-- END CUSTOM TEMPLATE OUTPUT from 'core/themes/olivero/templates/misc/status-messages.html.twig' --> <!-- END OUTPUT from 'core/modules/system/templates/block--system-messages-block.html.twig' --> <!-- END RENDERER --> </div>
- 🇬🇧United Kingdom danharper
My Gin admin theme seems to work fine.
If I remove the status message block from the frontend theme then messages still display but in the content region (still un styled) is this normal behaviour?
use Drupal\Core\Render\Element\StatusMessages; function yourtheme_preprocess_block__system_messages_block(&$variables) { $variables['content'] = StatusMessages::renderMessages(); }
My current fix is like this, but this will only fix from using core into radix, it didn't go through my custom template.
- 🇬🇧United Kingdom danharper
Applying the patch from that thread didn't solve the issue which appears to about sorting them.
I do have an error in my twig about invalid naming.
<!-- THEME DEBUG --> <!-- THEME HOOK: 'region' --> <!-- FILE NAME SUGGESTIONS: ✅ region--nowrap.html.twig ▪️ region--pre-content.html.twig ▪️ region.html.twig --> <!-- BEGIN OUTPUT from 'themes/contrib/bootstrap_barrio/templates/layout/region--nowrap.html.twig' --> <!-- THEME DEBUG --> <!-- THEME HOOK: 'block' --> <!-- FILE NAME SUGGESTIONS: ▪️ block--system-messages-block--pre-content.html.twig ▪️ block--system--pre-content.html.twig ▪️ block--pre-content--partshub-messages.html.twig ▪️ block--pre-content.html.twig ▪️ block--partshub-messages.html.twig ✅ block--system-messages-block.html.twig ▪️ block--system.html.twig ▪️ block.html.twig --> <!-- INVALID FILE NAME SUGGESTIONS: See https://api.drupal.org/api/drupal/core!lib!Drupal!Core!Render!theme.api.php/function/hook_theme_suggestions_alter --> <!-- BEGIN OUTPUT from 'core/modules/system/templates/block--system-messages-block.html.twig' -->
- 🇮🇳India Prashant.c Dharamshala
Could this https://www.drupal.org/project/drupal/issues/3270083 🐛 Some theme hooks are not invoking (depends on templates order provided by filesystem) Needs work be related I tried to make the changes as per but still not getting applied, however, If I dump <?PHP $templates = drupal_find_theme_templates($existing, '.html.twig', $path); ?> when the status message is displayed it returns the template name in the array.
array:109 [▼ "textarea" => array:2 [▶] "checkboxes" => array:2 [▶] "field_multiple_value_form" => array:2 [▶] "input" => array:2 [▶] "radios" => array:2 [▶] "toolbar" => array:2 [▶] "menu__toolbar" => array:4 [▶] "menu_local_task" => array:2 [▶] "views_view_table" => array:2 [▶] "views_ui_expose_filter_form" => array:2 [▶] "views_mini_pager" => array:2 [▶] "views_ui_display_tab_setting" => array:2 [▶] "views_ui_display_tab_bucket" => array:2 [▶] "views_ui_build_group_filter_form" => array:2 [▶] "admin_page" => array:2 [▶] "admin_block_content" => array:2 [▶] "system_modules_details" => array:2 [▶] "tablesort_indicator" => array:2 [▶] "indentation" => array:2 [▶] "search_result" => array:2 [▶] "node" => array:2 [▶] "mark" => array:2 [▶] "page_title" => array:2 [▶] "comment" => array:2 [▶] "taxonomy_term" => array:2 [▶] "username" => array:2 [▶] "user" => array:2 [▶] "menu" => array:2 [▶] "block__system_branding_block" => array:4 [▶] "block" => array:2 [▶] "block__system_menu_block" => array:4 [▶] "views_view_row_rss" => array:2 [▶] "views_view_summary_unformatted" => array:2 [▶] "views_view_summary" => array:2 [▶] "views_view_grouping" => array:2 [▶] "views_view" => array:2 [▶] "filter_caption" => array:2 [▶] "image" => array:2 [▶] "field__node__title" => array:4 [▶] "link_formatter_link_separate" => array:2 [▶] "field__node__uid" => array:4 [▶] "file_video" => array:2 [▶] "field__comment" => array:4 [▶] "field" => array:2 [▶] "file_audio" => array:2 [▶] "time" => array:2 [▶] "field__node__created" => array:4 [▶] "help_section" => array:2 [▶] "progress_bar" => array:2 [▶] "item_list" => array:2 [▶] "table" => array:2 [▶] "region" => array:2 [▶] "html" => array:2 [▶] "image_widget" => array:2 [▶] "file_widget_multiple" => array:2 [▶] "file_managed_file" => array:2 [▶] "filter_tips" => array:2 [▶] "filter_guidelines" => array:2 [▶] "file_link" => array:2 [▶] "status_messages" => array:2 [▼ "template" => "status-messages" "path" => "core/themes/claro/templates/misc" ] "status_report_general_info" => array:2 [▶] "off_canvas_page_wrapper" => array:2 [▶] "maintenance_page" => array:2 [▶] "datetime_wrapper" => array:2 [▶] "form_element_label" => array:2 [▶] "block_content_add_list" => array:2 [▶] "breadcrumb" => array:2 [▶] "status_report_counter" => array:2 [▶] "form_element" => array:2 [▶] "entity_add_list" => array:2 [▶] "menu_local_tasks" => array:2 [▶] "install_page" => array:2 [▶] "fieldset" => array:2 [▶] "datetime_form" => array:2 [▶] "status_report_page" => array:2 [▶] "node_edit_form" => array:2 [▶] "system_themes_page" => array:2 [▶] "status_report_grouped" => array:2 [▶] "pager" => array:2 [▶] "views_exposed_form" => array:2 [▶] "node_add_list" => array:2 [▶] "details" => array:2 [▶] "page" => array:2 [▶] "text_format_wrapper" => array:2 [▶] "menu_link_form" => array:2 [▶] "block__local_tasks_block" => array:4 [▶] "block__search_form_block" => array:4 [▶] "block__local_actions_block" => array:4 [▶] "region__breadcrumb" => array:4 [▶] "links__node" => array:4 [▶] "links__media_library_menu" => array:4 [▶] "item_list__media_library_add_form_media_list" => array:4 [▶] "item_list__search_results" => array:4 [▶] "maintenance_page__front" => array:4 [▶] "menu_local_task__views_ui" => array:4 [▶] "fieldset__media_library_widget" => array:4 [▶] "details__vertical_tabs" => array:4 [▶] "details__media_library_add_form_selected_media" => array:4 [▶] "container__text_format_filter_help" => array:4 [▶] "container__text_format_filter_wrapper" => array:4 [▶] "container__text_format_filter_guidelines" => array:4 [▶] "container__media_library_widget_selection" => array:4 [▶] "container__media_library_content" => array:4 [▶] "field__text" => array:4 [▶] "field__text_long" => array:4 [▶] "field__text_with_summary" => array:4 [▶] "views_ui_view_preview_section__exposed" => array:4 [▶] "views_view__media_library" => array:4 [▶] "views_view_unformatted__media_library" => array:4 [▶] ]
Same here. I'm using a custom theme that has Classy as the base theme.
- 🇧🇪Belgium f0ns
I am experiencing the same issue after updating to Drupal 10.3
status-messages.html.twig is not being suggested.
I'm using a custom theme that I made.
- 🇬🇧United Kingdom danharper
Getting the same issue.
status-messages.html.twig is not being suggested.
I'm getting the same as #10
I'm using a subtheme which of a conrib theme. After updating to 10.3 the styling disappeared because the template is not being suggested.
- 🇮🇳India Prashant.c Dharamshala
I tried with
- Drupal 10.3.0 composer installation
- Standard profile installation
- Tried with Olivero and Claro both the themes
Can't see the file
status-messages.html.twig
in TWIG debug output.Tried to add some HTML etc. and clearing cache nothing worked.
- 🇺🇸United States ACoolDevDude California
I tried what you suggested, and I am not getting any suggestions. I even went to manually update the Olivero twig template (just adding text of 'Hello World'), clearing caches, and still nothing.
This was done with a new minimal install, no custom modules.
- 🇬🇧United Kingdom danthorne Devon, UK
I've just set olivero as the default theme on my site and modified /themes/olivero/templates/misc/status-messages.html.twig myself. It did nothing.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
I've enabled twig debug in Drupal 10.3.x on the standard profile, install the system test module and used drush php to do
\Drupal::state()->set('system_test.front_page_output', 1);
and visited the front page.... I see<!-- THEME DEBUG --> <!-- THEME HOOK: 'status_messages' --> <!-- BEGIN OUTPUT from 'core/themes/olivero/templates/misc/status-messages.html.twig' -->
If I change core/themes/olivero/templates/misc/status-messages.html.twig then it affects the output.
So as I far as I can see this is working and has not changed.
- 🇺🇸United States cilefen
🐛 status message notification twig file name changed Postponed: needs info
- 🇺🇸United States cilefen
It may not be the cause. As I mentioned
git bisect
will identify the issue quickly. - 🇺🇸United States ACoolDevDude California
I noticed this too. I'm not sure how expanding the core theme suggestions for block view modes would remove the hook entirely for theme suggestions for the status_messages.
- 🇺🇸United States cilefen
I looked through every change record for that release. https://www.drupal.org/node/3304793 → stands out as possibly relevant. Could you investigate that?
Performing a
git bisect
on a Git checkout of Drupal Core between the release tag you were on and the release tag that introduced the regression will very quickly find the regression commit. - Issue created by @danthorne
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇨🇭Switzerland saschaeggi Zurich
Duplicate of 🐛 Save button missing in modal for editing media using Media Library Edit module Needs review
- 🇵🇱Poland besek
Just tested in linked issue. I think this one can be closed as Duplicate?
- 🇦🇹Austria hudri Austria
I think this is the same as #3455080 🐛 Save button missing in modal for editing media using Media Library Edit module Needs review
I already have created a MR there, spare some time to test it?
- 🇵🇱Poland besek
I have the same issue :(
I was trying to disable this new feature (which is great, if it would work on modal forms) by disabling option "Enable sticky action buttons" in Gin settings. However disabling this option didn't change anything.
For now, only option I found to make those modal forms work was downgrading gin to RC10 - Issue created by @DuaelFr