- 🇮🇹Italy luisasa
We also detect the problem in Chrome, in IE, in Opera.
Drupal core 9.5.5.
Both in login or logout the system runs empty. To resolve the user must click on a link and quickly manages to enter.
Also note an excessive slowdown of the system when loading pages, views ...
Is it possible to help us to solve the problem?
Thank you - 🇩🇪Germany Anybody Porta Westfalica
Sorry guys, I don't have the time to write a patch currently. If anyone has the time, please do it, including tests and I will review it quickly!
- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 3:07pm 2 May 2023 - 🇮🇳India Ranjit1032002
Created a patch for the issue mentioned, please review.
Thank You. - Status changed to Needs work
over 1 year ago 3:53pm 2 May 2023 - 🇩🇪Germany Anybody Porta Westfalica
Well that doesn't really help. It's just what has been written in the issue summary. What we need is a clean fix, explanation why it was used before, but should (perhaps?) not be used anymore and what are the consequences.
The result of #17 is just commented out code with unclear results from my perspective. Anyway I'll prepare a MR now which removes these lines to be used as workaround and have a look if I can find a blame entry where it was added ...
- @anybody opened merge request.
- 🇩🇪Germany Anybody Porta Westfalica
These lines were added here: 🐛 Service Worker caches admin toolbar and contextual links Fixed
So it seems this is a regression. I'll ask the users from that issue to have a look please.
- 🇩🇪Germany Anybody Porta Westfalica
I'm wondering if perhaps the (double) quotes may cause this?
'"storage"'
vs,'storage'
as string value?Could someone try that?
- @anybody opened merge request.
- Status changed to Needs review
over 1 year ago 4:03pm 2 May 2023 - 🇮🇹Italy kris77
This patch https://git.drupalcode.org/project/pwa/-/merge_requests/50.diff works for me
- 🇩🇪Germany Anybody Porta Westfalica
Thanks @Kris77 interesting to hear! That sounds good and if it also works for others, we should have a deeper look at the headers sent and if they work as expected (clearing those caches)!
- 🇮🇳India arunkumark Coimbatore
Verified the patch MR!50 it resolve the issue of user login and logout.
+RTBC
- 🇻🇳Vietnam phannphong Ho Chi Minh City
I don't face this issue when user logout but face the exactly issue when user login.
The patch MR!50 is solved my problem when user login. - 🇩🇪Germany Anybody Porta Westfalica
Could someone please compare and debug the mentioned
Clear-Site-Data
header with and without this patch?We need to be totally sure that this is the correct solution, before merging this. I don't have much time currently, sorry.
- 🇩🇪Germany Grevil
I couldn't recreate this issue under windows using Chrome Version 113.0.5672.93 (Official Build) (64-Bit) and Olivero 10.0.9.
Although the patch in MR 50 makes sense... @Anybody, how do you want to proceed here?
- 🇬🇪Georgia iamdroid
Hi folks, thanks for working on this.
I've tested MR!50 - it works!
+1 for RTBC.
- Status changed to RTBC
over 1 year ago 8:19am 16 May 2023 - 🇩🇪Germany Anybody Porta Westfalica
@Grevil: Thank you sooooo much, so my assumption was correct :D Whao!
Let's merge it!
- Status changed to Fixed
over 1 year ago 8:23am 16 May 2023 - Status changed to RTBC
over 1 year ago 8:24am 16 May 2023 - Status changed to Fixed
over 1 year ago 8:35am 16 May 2023 - 🇩🇪Germany Anybody Porta Westfalica
Cherry-picked to 2.x and created 8.x-1.7 and 2.0.0-rc2 with this fix included! Thank you all!
Automatically closed - issue fixed for 2 weeks with no activity.