Regression in SIMPLETEST environment skipping

Created on 27 April 2016, over 8 years ago
Updated 18 January 2024, 10 months ago
🐛 Bug report
Status

Needs work

Version

11.0 🔥

Component
PHPUnit 

Last updated 1 day ago

Created by

🇺🇸United States neclimdul Houston, TX

Live updates comments and jobs are added and updated live.
  • Regression

    It restores functionality that was present in earlier versions.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇺🇸United States neclimdul Houston, TX

    Doesn't look like this was fully working anymore and still had the old php class names so a bunch of updates.

    1) Moved this out of a dedicated listener and integrated it into the existing DrupalListener. This fixes the legacy PHPunit classes but also avoids changes to phpunit.xml files and avoids adding any deprecated code since listeners are technically deprecated now in PHPunit 8/9 to be removed in 10.
    2) Fixed the skipped logic in Functional tests that wasn't correctly triggering the Simpletest warning. This got lost I think accidentally in an earlier patch.
    3) Ported this logic to TestSiteApplicationTest as well.

    Alternatively this might be converted to PHPunit events? 10 requires PHPunit 9 so that would seem to be an option but I don't see that anywhere in core and I don't have any experience so I didn't move that far.

  • 🇺🇸United States neclimdul Houston, TX
Production build 0.71.5 2024