InfoParser returns an empty array if passed a non-existing file

I've gone for throwing an exception because returning an empty array and triggering a deprecation is not helpful. It took longer to work out why a test was failing because of the empty array behaviour. It just does not make sense.

I think going straight to the exception is correct here as it helps reveals broken assumptions. For example, \Drupal\KernelTests\Core\Theme\BaseThemeMissingTest is not testing what it thinks it is. It never actually reads the core/tests/fixtures/test_missing_base_theme/test_missing_base_theme.info.yml virtual file.

This also reveals that we should standardise how tests are run from the Drupal root directory so that Unit, Kernel, and Functional tests are all consistent.

Haven't reviewed the whole patch properly but +1 going straight to an exception here.

I went back through git history and this was added when the original patch for .info files went in, before that, modules were discovered via the presence of a .module file, so it was a bc layer for shipping .module and no .info.

Now, .info.yml is how we identify modules/extensions at all, so an extension without a .info.yml is impossible (outside of weird tests).

Creditting @catch for git archaeology.

Rebased so I could use our fancy new test-only feature

1) Drupal\Tests\Core\Extension\InfoParserUnitTest::testInfoParserNonExisting
Failed asserting that exception of type "\Drupal\Core\Extension\InfoParserException" is thrown.
/builds/issue/drupal-3391776/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:122
/builds/issue/drupal-3391776/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
/builds/issue/drupal-3391776/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
/builds/issue/drupal-3391776/vendor/phpunit/phpunit/src/Framework/TestSuite.php:684
/builds/issue/drupal-3391776/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:651
/builds/issue/drupal-3391776/vendor/phpunit/phpunit/src/TextUI/Command.php:144
/builds/issue/drupal-3391776/vendor/phpunit/phpunit/src/TextUI/Command.php:97
FAILURES!

Updated the IS slightly to show we are just throwing an exception and not deprecation.

looking at the changes nothing is glaring. If anything seems some old crust is getting thrown out.

LGTM.

This is a behaviour change but really is just removing cruft; I can't see how this would affect anything other than tests with incorrect assumptions, so I think this is eligible for the beta branch.

Committed and pushed 5ef2211afc to 11.x and d80db4487c to 10.2.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.