- ๐บ๐ธUnited States jcandan
Got a test added and refactored the work from the above patches and MR !8. Good job and thanks , everyone.
Please, someone review MR !9.
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
The issue tag for Commerce is Commerce 2.x. Since somebody used another tag, that has been renamed Commerce 2.x (duplicate) to make clear it should not be used.
- ๐บ๐ธUnited States jcandan
Never mind. That
intlTelInputWithUtils.js
doesn't even come with the package. Must be outdated docs. - ๐บ๐ธUnited States jcandan
Option 1: intlTelInputWithUtils
If you're not concerned about filesize (e.g. you're lazy loading this script), the easiest thing to do is to just use the full bundle (/build/js/intlTelInputWithUtils.js), which comes with the utils script included. This script can be used exactly like the main intlTelInput.js - so it can either be loaded directly onto the page (which defines window.intlTelInput like usual), or it can be imported like so: import intlTelInput from "intl-tel-input/intlTelInputWithUtils".
-- https://github.com/jackocnr/intl-tel-input?tab=readme-ov-file#loading-th...Given this is loaded when the widget is used, let's adopt the above implementation in lieu of the changes made from #11.
- @jcandan opened merge request.
- ๐บ๐ธUnited States jcandan
This is a big undertaking. While I do believe it is ideal to tackle issues distinctly, the frequency of updates to this module has made it such that a big change affecting multiple bugs is inevitable. I will review this further. I plan to add tests as described in #10. Thanks, everyone.
- ๐บ๐ธUnited States jcandan
I think I see what happened. It seems Ahmad's #17 patch mistakenly missed somethings, #18 is a re-roll of #12 with his desired change to INTERNATIONAL format rather than E164.